summaryrefslogtreecommitdiff
path: root/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
diff options
context:
space:
mode:
authormitaclaw <140017135+mitaclaw@users.noreply.github.com>2024-05-24 16:44:43 -0700
committermitaclaw <140017135+mitaclaw@users.noreply.github.com>2024-05-25 06:22:45 -0700
commit3b214a4978129a96b136aa23ce9ca5843fb3e3f4 (patch)
tree2daad053934e41c882e6c2684496f8d950d825b1 /Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
parent4a2ec86a9a5bfaeefa2bb108c8d3fd7158f22d69 (diff)
BranchWatchDialog: Resolve Linux FIXME
This stopped being an issue for me with a recent package update, so I guess Qt6 was fixed upstream?
Diffstat (limited to 'Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp')
-rw-r--r--Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp16
1 files changed, 5 insertions, 11 deletions
diff --git a/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp b/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
index e35259d2d2..c20b2e3c2d 100644
--- a/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
+++ b/Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
@@ -207,7 +207,6 @@ BranchWatchDialog::BranchWatchDialog(Core::System& system, Core::BranchWatch& br
{
setWindowTitle(tr("Branch Watch Tool"));
setWindowFlags((windowFlags() | Qt::WindowMinMaxButtonsHint) & ~Qt::WindowContextHelpButtonHint);
- SetQWidgetWindowDecorations(this);
setLayout([this, &ppc_symbol_db]() {
auto* main_layout = new QVBoxLayout;
@@ -241,6 +240,11 @@ BranchWatchDialog::BranchWatchDialog(Core::System& system, Core::BranchWatch& br
table_view->setEditTriggers(QAbstractItemView::NoEditTriggers);
table_view->setCornerButtonEnabled(false);
table_view->verticalHeader()->hide();
+ table_view->setColumnWidth(Column::Instruction, 50);
+ table_view->setColumnWidth(Column::Condition, 50);
+ table_view->setColumnWidth(Column::OriginSymbol, 250);
+ table_view->setColumnWidth(Column::DestinSymbol, 250);
+ // The default column width (100 units) is fine for the rest.
QHeaderView* const horizontal_header = table_view->horizontalHeader();
horizontal_header->restoreState( // Restore column visibility state.
@@ -502,16 +506,6 @@ BranchWatchDialog::BranchWatchDialog(Core::System& system, Core::BranchWatch& br
return main_layout;
}());
- // FIXME: On Linux, Qt6 has recently been resetting column widths to their defaults in many
- // unexpected ways. This affects all kinds of QTables in Dolphin's GUI, so to avoid it in
- // this QTableView, I have deferred this operation. Any earlier, and this would be undone.
- // SetQWidgetWindowDecorations was moved to before these operations for the same reason.
- m_table_view->setColumnWidth(Column::Instruction, 50);
- m_table_view->setColumnWidth(Column::Condition, 50);
- m_table_view->setColumnWidth(Column::OriginSymbol, 250);
- m_table_view->setColumnWidth(Column::DestinSymbol, 250);
- // The default column width (100 units) is fine for the rest.
-
const auto& settings = Settings::GetQSettings();
restoreGeometry(settings.value(QStringLiteral("branchwatchdialog/geometry")).toByteArray());
}