CodeDiffDialog: Construct Diff instance in CalculateSymbolsFromProfile() when necessary

We can move the construction of the Diff instance into the body of the
if statement, so that we only construct this if the condition is true.

While we're at it, we can move the symbol description string into the
instance, getting rid of a copy. The function itself can also be const
qualified.

1 files changed, 1 insertions, 1 deletions

diff --git a/Source/Core/DolphinQt/Debugger/CodeDiffDialog.h b/Source/Core/DolphinQt/Debugger/CodeDiffDialog.h
index ac156dea91..3278359afe 100644
--- a/Source/Core/DolphinQt/Debugger/CodeDiffDialog.h
+++ b/Source/Core/DolphinQt/Debugger/CodeDiffDialog.h
@@ -38,7 +38,7 @@ private:
   void ClearBlockCache();

   void OnClickItem();

   void OnRecord(bool enabled);

-  std::vector<Diff> CalculateSymbolsFromProfile();

+  std::vector<Diff> CalculateSymbolsFromProfile() const;

   void OnInclude();

   void OnExclude();

   void RemoveMissingSymbolsFromIncludes(const std::vector<Diff>& symbol_diff);