summaryrefslogtreecommitdiff
path: root/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
diff options
context:
space:
mode:
authorMartino Fontana <tinozzo123@gmail.com>2024-06-15 11:23:50 +0200
committerMartino Fontana <tinozzo123@gmail.com>2024-07-02 18:29:42 +0200
commit037de1ce929b9c785f11e9f595ededd1497bfe41 (patch)
tree9c406e41eb538f2cc7f5318cdedcad5f8913c346 /Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
parent8235c38df79bd48ae3d84fe35471befb6f0ce5eb (diff)
Debugger: fix Run to Here
Now it actually does what it says on the name, instead of creating a breapoint and doing nothing else (not even updating the widget). Also, it now can't be selected if emulation isn't running. Closes https://bugs.dolphin-emu.org/issues/13532
Diffstat (limited to 'Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp')
-rw-r--r--Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp10
1 files changed, 4 insertions, 6 deletions
diff --git a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
index e2df3420a6..36e7ade321 100644
--- a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
+++ b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
@@ -594,7 +594,7 @@ void CodeViewWidget::OnContextMenu()
menu->addAction(tr("Set symbol &end address"), this, &CodeViewWidget::OnSetSymbolEndAddress);
menu->addSeparator();
- menu->addAction(tr("Run &To Here"), this, &CodeViewWidget::OnRunToHere);
+ auto* run_to_action = menu->addAction(tr("Run &To Here"), this, &CodeViewWidget::OnRunToHere);
auto* function_action =
menu->addAction(tr("&Add function"), this, &CodeViewWidget::OnAddFunction);
auto* ppc_action = menu->addAction(tr("PPC vs Host"), this, &CodeViewWidget::OnPPCComparison);
@@ -645,8 +645,8 @@ void CodeViewWidget::OnContextMenu()
follow_branch_action->setEnabled(follow_branch_enabled);
for (auto* action :
- {copy_address_action, copy_line_action, copy_hex_action, function_action, ppc_action,
- insert_blr_action, insert_nop_action, replace_action, assemble_action})
+ {copy_address_action, copy_line_action, copy_hex_action, function_action, run_to_action,
+ ppc_action, insert_blr_action, insert_nop_action, replace_action, assemble_action})
{
action->setEnabled(running);
}
@@ -869,9 +869,7 @@ void CodeViewWidget::OnRunToHere()
{
const u32 addr = GetContextAddress();
- m_system.GetPowerPC().GetDebugInterface().AddBreakpoint(addr);
- m_system.GetPowerPC().GetDebugInterface().RunToBreakpoint();
- Update();
+ m_system.GetPowerPC().GetDebugInterface().RunTo(addr);
}
void CodeViewWidget::OnPPCComparison()