summaryrefslogtreecommitdiff
path: root/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
diff options
context:
space:
mode:
authorAdmiral H. Curtiss <pikachu025@gmail.com>2020-02-23 18:49:18 +0100
committerAdmiral H. Curtiss <pikachu025@gmail.com>2020-02-23 18:49:27 +0100
commitc70e004f53f7ab15794b4ad631a82ed6f14ca934 (patch)
tree6f5583d1ab66eb85083ba05ff409e6ed3b68dc48 /Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
parentedad018213186fa9cae6fe0785462377afa02bac (diff)
Qt/CodeViewWidget: Use named constants for column IDs.
Diffstat (limited to 'Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp')
-rw-r--r--Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp23
1 files changed, 15 insertions, 8 deletions
diff --git a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
index 48bc8b240a..e511c1bda3 100644
--- a/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
+++ b/Source/Core/DolphinQt/Debugger/CodeViewWidget.cpp
@@ -36,9 +36,16 @@ constexpr double SCROLL_FRACTION_DEGREES = 15.;
constexpr size_t VALID_BRANCH_LENGTH = 10;
+constexpr int CODE_VIEW_COLUMN_BREAKPOINT = 0;
+constexpr int CODE_VIEW_COLUMN_ADDRESS = 1;
+constexpr int CODE_VIEW_COLUMN_INSTRUCTION = 2;
+constexpr int CODE_VIEW_COLUMN_PARAMETERS = 3;
+constexpr int CODE_VIEW_COLUMN_DESCRIPTION = 4;
+constexpr int CODE_VIEW_COLUMNCOUNT = 5;
+
CodeViewWidget::CodeViewWidget()
{
- setColumnCount(5);
+ setColumnCount(CODE_VIEW_COLUMNCOUNT);
setShowGrid(false);
setContextMenuPolicy(Qt::CustomContextMenu);
setSelectionMode(QAbstractItemView::SingleSelection);
@@ -86,7 +93,7 @@ void CodeViewWidget::FontBasedSizing()
const int rowh = fm.height() + 1;
verticalHeader()->setMaximumSectionSize(rowh);
horizontalHeader()->setMinimumSectionSize(rowh + 5);
- setColumnWidth(0, rowh + 5);
+ setColumnWidth(CODE_VIEW_COLUMN_BREAKPOINT, rowh + 5);
Update();
}
@@ -189,11 +196,11 @@ void CodeViewWidget::Update()
Resources::GetScaledThemeIcon("debugger_breakpoint").pixmap(QSize(rowh - 2, rowh - 2)));
}
- setItem(i, 0, bp_item);
- setItem(i, 1, addr_item);
- setItem(i, 2, ins_item);
- setItem(i, 3, param_item);
- setItem(i, 4, description_item);
+ setItem(i, CODE_VIEW_COLUMN_BREAKPOINT, bp_item);
+ setItem(i, CODE_VIEW_COLUMN_ADDRESS, addr_item);
+ setItem(i, CODE_VIEW_COLUMN_INSTRUCTION, ins_item);
+ setItem(i, CODE_VIEW_COLUMN_PARAMETERS, param_item);
+ setItem(i, CODE_VIEW_COLUMN_DESCRIPTION, description_item);
if (addr == GetAddress())
{
@@ -559,7 +566,7 @@ void CodeViewWidget::mousePressEvent(QMouseEvent* event)
switch (event->button())
{
case Qt::LeftButton:
- if (column(item) == 0)
+ if (column(item) == CODE_VIEW_COLUMN_BREAKPOINT)
ToggleBreakpoint();
else
SetAddress(addr, SetAddressUpdate::WithUpdate);