Merge pull request #8231 from JosJuice/debugger-hidden

DolphinQt: Don't update debug widgets when hidden

1 files changed, 16 insertions, 8 deletions

diff --git a/Source/Core/DolphinQt/Debugger/RegisterWidget.cpp b/Source/Core/DolphinQt/Debugger/RegisterWidget.cpp
index 0c829ed6df..7d2c61d88b 100644
--- a/Source/Core/DolphinQt/Debugger/RegisterWidget.cpp
+++ b/Source/Core/DolphinQt/Debugger/RegisterWidget.cpp
@@ -38,14 +38,7 @@ RegisterWidget::RegisterWidget(QWidget* parent) : QDockWidget(parent)
   PopulateTable();
   ConnectWidgets();
 
-  connect(Host::GetInstance(), &Host::UpdateDisasmDialog, this, [this] {
-    if (Settings::Instance().IsDebugModeEnabled() && Core::GetState() == Core::State::Paused)
-    {
-      m_updating = true;
-      emit UpdateTable();
-      m_updating = false;
-    }
-  });
+  connect(Host::GetInstance(), &Host::UpdateDisasmDialog, this, &RegisterWidget::Update);
 
   connect(&Settings::Instance(), &Settings::RegistersVisibilityChanged,
           [this](bool visible) { setHidden(!visible); });
@@ -68,6 +61,11 @@ void RegisterWidget::closeEvent(QCloseEvent*)
   Settings::Instance().SetRegistersVisible(false);
 }
 
+void RegisterWidget::showEvent(QShowEvent* event)
+{
+  Update();
+}
+
 void RegisterWidget::CreateWidgets()
 {
   m_table = new QTableWidget;
@@ -375,3 +373,13 @@ void RegisterWidget::AddRegister(int row, int column, RegisterType type, std::st
 
   connect(this, &RegisterWidget::UpdateTable, [value] { value->RefreshValue(); });
 }
+
+void RegisterWidget::Update()
+{
+  if (isVisible() && Core::GetState() == Core::State::Paused)
+  {
+    m_updating = true;
+    emit UpdateTable();
+    m_updating = false;
+  }
+}