diff options
| author | Martino Fontana <tinozzo123@gmail.com> | 2026-04-06 11:37:26 +0200 |
|---|---|---|
| committer | Martino Fontana <tinozzo123@gmail.com> | 2026-04-17 12:39:46 +0200 |
| commit | 95dec132030e72b74da6bc46966e4fe5e4e239c0 (patch) | |
| tree | f4340655ebc036425e69048651ee49dec16ddc12 /Source/Core/DolphinQt/TAS/TASInputWindow.cpp | |
| parent | 33f62b0f9f36a3dfccc3ecfc13358899d0cc8036 (diff) | |
Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.
Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.
Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
Diffstat (limited to 'Source/Core/DolphinQt/TAS/TASInputWindow.cpp')
| -rw-r--r-- | Source/Core/DolphinQt/TAS/TASInputWindow.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Source/Core/DolphinQt/TAS/TASInputWindow.cpp b/Source/Core/DolphinQt/TAS/TASInputWindow.cpp index 7b2cff94a0..227b04759f 100644 --- a/Source/Core/DolphinQt/TAS/TASInputWindow.cpp +++ b/Source/Core/DolphinQt/TAS/TASInputWindow.cpp @@ -166,8 +166,8 @@ QGridLayout* TASInputWindow::CreateSliderValuePairLayout( TASSpinBox* TASInputWindow::CreateSliderValuePair( std::string_view group_name, std::string_view control_name, InputOverrider* overrider, QGridLayout* layout, int zero, int default_, int min, int max, - QKeySequence shortcut_key_sequence, Qt::Orientation orientation, QWidget* shortcut_widget, - std::optional<ControlState> scale) + const QKeySequence& shortcut_key_sequence, Qt::Orientation orientation, + QWidget* shortcut_widget, std::optional<ControlState> scale) { TASSpinBox* value = CreateSliderValuePair(layout, default_, max, shortcut_key_sequence, orientation, shortcut_widget); @@ -194,7 +194,7 @@ TASSpinBox* TASInputWindow::CreateSliderValuePair( // The shortcut_widget argument needs to specify the container widget that will be hidden/shown. // This is done to avoid ambiguous shortcuts TASSpinBox* TASInputWindow::CreateSliderValuePair(QGridLayout* layout, int default_, int max, - QKeySequence shortcut_key_sequence, + const QKeySequence& shortcut_key_sequence, Qt::Orientation orientation, QWidget* shortcut_widget) { |