Merge pull request #11954 from Minty-Meeo/dolphin-tool-code-review-3

DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE

1 files changed, 6 insertions, 5 deletions

diff --git a/Source/Core/DolphinTool/VerifyCommand.cpp b/Source/Core/DolphinTool/VerifyCommand.cpp
index c27c02c646..3c3af0d358 100644
--- a/Source/Core/DolphinTool/VerifyCommand.cpp
+++ b/Source/Core/DolphinTool/VerifyCommand.cpp
@@ -3,6 +3,7 @@
 
 #include "DolphinTool/VerifyCommand.h"
 
+#include <cstdlib>
 #include <string>
 #include <vector>
 
@@ -112,7 +113,7 @@ int VerifyCommand(const std::vector<std::string>& args)
   if (input_file_path.empty())
   {
     std::cerr << "Error: No input set" << std::endl;
-    return 1;
+    return EXIT_FAILURE;
   }
 
   DiscIO::Hashes<bool> hashes_to_calculate{};
@@ -136,7 +137,7 @@ int VerifyCommand(const std::vector<std::string>& args)
   {
     // optparse should protect from this
     std::cerr << "Error: No algorithms selected for the operation" << std::endl;
-    return 1;
+    return EXIT_FAILURE;
   }
 
   // Open the volume
@@ -144,7 +145,7 @@ int VerifyCommand(const std::vector<std::string>& args)
   if (!volume)
   {
     std::cerr << "Error: Unable to open disc image" << std::endl;
-    return 1;
+    return EXIT_FAILURE;
   }
 
   // Verify the volume
@@ -173,10 +174,10 @@ int VerifyCommand(const std::vector<std::string>& args)
     else
     {
       std::cerr << "Error: No hash computed" << std::endl;
-      return 1;
+      return EXIT_FAILURE;
     }
   }
 
-  return 0;
+  return EXIT_SUCCESS;
 }
 }  // namespace DolphinTool