diff options
| author | Lioncash <mathew1800@gmail.com> | 2014-11-11 09:50:11 -0500 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2014-11-11 09:50:16 -0500 |
| commit | 892bbdade669def297b0469509dd648fef6478bd (patch) | |
| tree | 7398436a807d1f1f19c45e30c3722ef58abedd0e /Source/Core/DolphinWX/Debugger/MemoryView.cpp | |
| parent | 71d8165a8649cde73663b1534bbdd6094faecf2d (diff) | |
DolphinWX: Eliminate some memory leaks
Since the menus aren't actually assigned a parent, they would not be freed by wx. Plus, these should have initially been constructed on the stack in the first place.
Technically any time someone right-clicked the game list they would be leaking memory.
Diffstat (limited to 'Source/Core/DolphinWX/Debugger/MemoryView.cpp')
| -rw-r--r-- | Source/Core/DolphinWX/Debugger/MemoryView.cpp | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/Source/Core/DolphinWX/Debugger/MemoryView.cpp b/Source/Core/DolphinWX/Debugger/MemoryView.cpp index d690f1f56d..86b0215f2a 100644 --- a/Source/Core/DolphinWX/Debugger/MemoryView.cpp +++ b/Source/Core/DolphinWX/Debugger/MemoryView.cpp @@ -221,22 +221,22 @@ void CMemoryView::OnPopupMenu(wxCommandEvent& event) void CMemoryView::OnMouseDownR(wxMouseEvent& event) { // popup menu - wxMenu* menu = new wxMenu; + wxMenu menu; //menu.Append(IDM_GOTOINMEMVIEW, _("&Goto in mem view")); #if wxUSE_CLIPBOARD - menu->Append(IDM_COPYADDRESS, _("Copy &address")); - menu->Append(IDM_COPYHEX, _("Copy &hex")); + menu.Append(IDM_COPYADDRESS, _("Copy &address")); + menu.Append(IDM_COPYHEX, _("Copy &hex")); #endif - menu->Append(IDM_WATCHADDRESS, _("Add to &watch")); - menu->Append(IDM_TOGGLEMEMORY, _("Toggle &memory")); + menu.Append(IDM_WATCHADDRESS, _("Add to &watch")); + menu.Append(IDM_TOGGLEMEMORY, _("Toggle &memory")); - wxMenu* viewAsSubMenu = new wxMenu; - viewAsSubMenu->Append(IDM_VIEWASFP, _("FP value")); - viewAsSubMenu->Append(IDM_VIEWASASCII, "ASCII"); - viewAsSubMenu->Append(IDM_VIEWASHEX, _("Hex")); - menu->AppendSubMenu(viewAsSubMenu, _("View As:")); + wxMenu viewAsSubMenu; + viewAsSubMenu.Append(IDM_VIEWASFP, _("FP value")); + viewAsSubMenu.Append(IDM_VIEWASASCII, "ASCII"); + viewAsSubMenu.Append(IDM_VIEWASHEX, _("Hex")); + menu.AppendSubMenu(&viewAsSubMenu, _("View As:")); - PopupMenu(menu); + PopupMenu(&menu); } void CMemoryView::OnPaint(wxPaintEvent& event) |