Fix crash when pressing Tab

When pressing Tab for a long time, Dolphin will sooner or later crash
because the result of FindFocus() has become NULL (toctou).

1 files changed, 7 insertions, 4 deletions

diff --git a/Source/Core/DolphinWX/Frame.cpp b/Source/Core/DolphinWX/Frame.cpp
index c7134167cf..87fb799616 100644
--- a/Source/Core/DolphinWX/Frame.cpp
+++ b/Source/Core/DolphinWX/Frame.cpp
@@ -706,13 +706,16 @@ bool CFrame::RendererHasFocus()
 	if (m_RenderParent->GetParent()->GetHWND() == GetForegroundWindow())
 		return true;
 #else
-	if (wxWindow::FindFocus() == nullptr)
+	wxWindow *window = wxWindow::FindFocus();
+	if (window == nullptr)
 		return false;
 	// Why these different cases?
-	if (m_RenderParent == wxWindow::FindFocus() ||
-			m_RenderParent == wxWindow::FindFocus()->GetParent() ||
-			m_RenderParent->GetParent() == wxWindow::FindFocus()->GetParent())
+	if (m_RenderParent == window ||
+	    m_RenderParent == window->GetParent() ||
+	    m_RenderParent->GetParent() == window->GetParent())
+	{
 		return true;
+	}
 #endif
 	return false;
 }