Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

4 files changed, 6 insertions, 6 deletions

diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp
index 612310a470..65926a2524 100644
--- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp
+++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.cpp
@@ -4,6 +4,7 @@
 #include "InputCommon/ControllerEmu/ControlGroup/Buttons.h"
 
 #include <string>
+#include <utility>
 
 namespace ControllerEmu
 {
@@ -11,8 +12,8 @@ Buttons::Buttons(const std::string& name_) : Buttons(name_, name_)
 {
 }
 
-Buttons::Buttons(const std::string& ini_name, const std::string& group_name)
-    : ControlGroup(ini_name, group_name, GroupType::Buttons)
+Buttons::Buttons(std::string ini_name, std::string group_name)
+    : ControlGroup(std::move(ini_name), std::move(group_name), GroupType::Buttons)
 {
 }
 
diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.h b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.h
index db61f1b8b2..68784310bb 100644
--- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.h
+++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/Buttons.h
@@ -15,7 +15,7 @@ class Buttons : public ControlGroup
 {
 public:
   explicit Buttons(const std::string& name_);
-  Buttons(const std::string& ini_name, const std::string& group_name);
+  Buttons(std::string ini_name, std::string group_name);
 
   template <typename C>
   void GetState(C* const buttons, const C* bitmasks) const
diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.cpp b/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.cpp
index 7a34d1c597..239289e748 100644
--- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.cpp
+++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.cpp
@@ -13,8 +13,7 @@
 
 namespace ControllerEmu
 {
-ModifySettingsButton::ModifySettingsButton(std::string button_name)
-    : Buttons(std::move(button_name))
+ModifySettingsButton::ModifySettingsButton(const std::string& button_name) : Buttons(button_name)
 {
 }
 
diff --git a/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h b/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h
index af4a80e94f..6b117eda4d 100644
--- a/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h
+++ b/Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h
@@ -13,7 +13,7 @@ namespace ControllerEmu
 class ModifySettingsButton : public Buttons
 {
 public:
-  explicit ModifySettingsButton(std::string button_name);
+  explicit ModifySettingsButton(const std::string& button_name);
 
   void AddInput(std::string button_name, bool toggle = false);