diff options
| author | Pokechu22 <Pokechu022@gmail.com> | 2022-06-13 19:24:37 -0700 |
|---|---|---|
| committer | Pokechu22 <Pokechu022@gmail.com> | 2022-06-14 12:22:06 -0700 |
| commit | 41939eeaf9850f8c0859292720ed3d8101e0e70c (patch) | |
| tree | 8e801377f09f1973c9afac82cd0c32ef1adab46a /Source/Core/InputCommon/ControllerInterface/Android/Android.cpp | |
| parent | 6a2ec825a225d07208d61aeeaf62c3c5525745f0 (diff) | |
DSPDisassembler: Fix disassembly of LSR and ASR
Before, both 1441 and 147f would disassemble as `lsr $acc0, #1`, when the second should be `lsr $acc0, #-1`, and both 14c1 and 14ff would be `asr $acc0, #1` when the second should be `asr $acc0, #-1`. I'm not entirely sure whether the minus signs actually make sense here, but this change is consistent with the assembler so that's an improvement at least.
devkitPro previously changed the formatting to not require negative signs for lsr and asr; this is probably something we should do in the future: https://github.com/devkitPro/gamecube-tools/commit/8a65c85c9b4748ed3dab3c0c85aeb0df95d58cfb
This fixes the HermesText and HermesBinary tests (HermesText already wrote `lsr $ACC0, #-5`, so this is consistent with what it used before.)
Diffstat (limited to 'Source/Core/InputCommon/ControllerInterface/Android/Android.cpp')
0 files changed, 0 insertions, 0 deletions