diff options
| author | Filoppi <filippotarpini@hotmail.it> | 2023-05-24 22:58:30 +0300 |
|---|---|---|
| committer | Filoppi <filippotarpini@hotmail.it> | 2023-12-18 21:45:22 +0200 |
| commit | e456bef163c1b667ff5a045a4bda66b30326ae90 (patch) | |
| tree | ec2483dc88b79eb0ec9f510e31d692b86c693b6e /Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp | |
| parent | e498759d1425a64ecf19524dc3196f103354e033 (diff) | |
Input: Improve Controller Interface devices threading
This specific issue was already addressed by https://github.com/dolphin-emu/dolphin/pull/11635
though I felt like there was something more we could do, and wasn't too happy with the
likelihood of devices update calls being skipped (due to `m_devices_population_mutex` being locked).
Diffstat (limited to 'Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp')
| -rw-r--r-- | Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp b/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp index ac0123aedd..3bf4020ad5 100644 --- a/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp +++ b/Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp @@ -18,6 +18,11 @@ #include <Windows.h> #endif +namespace ciface::Core +{ +class Device; +} + namespace ciface::SDL { static std::string GetJoystickName(int index) @@ -35,7 +40,7 @@ public: InputBackend(ControllerInterface* controller_interface); ~InputBackend(); void PopulateDevices() override; - void UpdateInput() override; + void UpdateInput(std::vector<std::weak_ptr<ciface::Core::Device>>& devices_to_remove) override; private: void OpenAndAddDevice(int index); @@ -637,7 +642,7 @@ void Joystick::Motor::SetState(ControlState state) } #endif -void InputBackend::UpdateInput() +void InputBackend::UpdateInput(std::vector<std::weak_ptr<ciface::Core::Device>>& devices_to_remove) { SDL_JoystickUpdate(); } |
