summaryrefslogtreecommitdiff
path: root/Source/Core/InputCommon/ControllerInterface/evdev/evdev.cpp
diff options
context:
space:
mode:
authorLéo Lam <leo@innovatetechnologi.es>2019-05-11 16:26:03 +0200
committerLéo Lam <leo@innovatetechnologi.es>2019-05-11 16:36:42 +0200
commit7c46497f0472f633cfea153c4c86d8c04cf04d8a (patch)
treeffb00b2a0db2dc6ef80866bdb89ebf9f58f02c36 /Source/Core/InputCommon/ControllerInterface/evdev/evdev.cpp
parenta0a0a688018a470f702361e56e37bde44a96afca (diff)
Fix a race condition when shutting down audio stream
The main EmuThread (in Core) is responsible for both initialising the audio stream and shutting it down properly. When the core is shutting down (when state is State::PowerDown), it is possible that the CPU or CPU-GPU thread and the UI thread will both try to stop the audio stream at the same time, which is an issue because some audio backends such as cubeb are not thread-safe. This commit prevents the race from ever happening in the first place by removing the call to AudioCommon::SetSoundStreamRunning from CPU::RunAdjacentSystems, which is actually completely unnecessary when shutting down because Core::EmuThread is going to stop the stream and perform more cleanup anyway. Should fix https://bugs.dolphin-emu.org/issues/11722
Diffstat (limited to 'Source/Core/InputCommon/ControllerInterface/evdev/evdev.cpp')
0 files changed, 0 insertions, 0 deletions