diff options
| author | Techjar <tecknojar@gmail.com> | 2018-11-19 05:30:39 -0500 |
|---|---|---|
| committer | Techjar <tecknojar@gmail.com> | 2018-11-19 05:45:32 -0500 |
| commit | 529796bd590c36c03978a43f1ee6eed0f4cba29d (patch) | |
| tree | 58366089f2203297885b16ed7c9efd00d1c60686 /Source/Core/InputCommon/ControllerInterface/evdev | |
| parent | e6b2758ab401975c0bde2b80bec5b05485c25c5a (diff) | |
NetPlay: Remove PadMapping type
Its usage was inconsistent, confusing, and buggy, so I opted to just
remove it entirely. It has been replaced with PadIndex for the
appropriate instances (mainly networking), and inappropriate usages
(where it was really just a player ID) have been replaced with the
PlayerId type. The definition of "no mapping" has been changed from -1
to 0 to match the defintion of "no player", as -1 (255 unsigned) is
actually a valid player ID.
The bugs never manifested because it only occurs with a full lobby of
255 players, at which point the last player's ID collides with the "no
mapping" definition and some undefined behavior occurs. Nevertheless, I
thought it best to fix it anyways as the usage of PadMapping was
confusing.
Diffstat (limited to 'Source/Core/InputCommon/ControllerInterface/evdev')
0 files changed, 0 insertions, 0 deletions