diff options
| author | Andrew de los Reyes <adlr@chromium.org> | 2012-03-16 21:08:27 -0700 |
|---|---|---|
| committer | Andrew de los Reyes <adlr@chromium.org> | 2012-03-18 15:11:34 -0700 |
| commit | d6d52920ec2f8c5d2ae74a219d16d211ecf45af9 (patch) | |
| tree | 4659874b4fed6c4690c549316d0d651ff6a016ec /Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp | |
| parent | ed3f9ce288ba3a74b263d2267e5bba96da3f0829 (diff) | |
Fix segfault in LogWindow on Mac
Commit 9ddb67d4a96a53698a71a7f3c8936c2437dd81de seems to have
introduced a segfault on Mac. The issue is that it this change casts
wxConvCurrent (which is a wxMBConvLibc) to a wxCSConv. This is an
unsafe cast because wxCSConv has member variables, but wxMBConvLibc
does not.
In LogWindow.cpp, the constructor for m_SJISConv is dereferencing one
of those member variables, which is a dereference of uninitialized
memory!
This CL reverts to the older (non-crashing) constructor, but keeps the
behavior the same.
Diffstat (limited to 'Source/Core/InputCommon/Src/ControllerInterface/ControllerInterface.cpp')
0 files changed, 0 insertions, 0 deletions