summaryrefslogtreecommitdiff
path: root/Source/Core/InputCommon
diff options
context:
space:
mode:
authorLioncash <mai.iam2048@gmail.com>2023-12-12 14:03:39 -0500
committerLioncash <mai.iam2048@gmail.com>2023-12-12 14:03:41 -0500
commitded2d55438fa010cd162c9f77d97ad530f89bb24 (patch)
tree426504562a56932ed6935dfc2a8fcfa90c948c62 /Source/Core/InputCommon
parenta5bbeb721a0ef622158cef10e5bd080106d23559 (diff)
ExpressionParser: Avoid some miscellaneous copies
Just some trivial copies that can be eliminated or turned into moves.
Diffstat (limited to 'Source/Core/InputCommon')
-rw-r--r--Source/Core/InputCommon/ControlReference/ExpressionParser.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
index 1c6b00c715..414a5aa888 100644
--- a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
+++ b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
@@ -248,7 +248,7 @@ ParseStatus Lexer::Tokenize(std::vector<Token>& tokens)
class ControlExpression : public Expression
{
public:
- explicit ControlExpression(ControlQualifier qualifier) : m_qualifier(qualifier) {}
+ explicit ControlExpression(ControlQualifier qualifier) : m_qualifier(std::move(qualifier)) {}
ControlState GetValue() const override
{
@@ -448,7 +448,7 @@ private:
const ControlState m_value{};
};
-static ParseResult MakeLiteralExpression(Token token)
+static ParseResult MakeLiteralExpression(const Token& token)
{
ControlState val{};
if (TryParse(token.data, &val))
@@ -460,7 +460,7 @@ static ParseResult MakeLiteralExpression(Token token)
class VariableExpression : public Expression
{
public:
- explicit VariableExpression(std::string name) : m_name(name) {}
+ explicit VariableExpression(std::string name) : m_name(std::move(name)) {}
ControlState GetValue() const override { return m_variable_ptr ? *m_variable_ptr : 0; }