diff options
| author | Dentomologist <dentomologist@gmail.com> | 2026-03-29 17:18:09 -0700 |
|---|---|---|
| committer | Dentomologist <dentomologist@gmail.com> | 2026-03-31 12:44:47 -0700 |
| commit | 68ac3d651d94f904d8847dc3cefb85b2394aa0c6 (patch) | |
| tree | c27211b06fd325ae00596500fe2251254c48485b /Source/Core/UICommon | |
| parent | f86bbc3b1d0b99543f4427b278e64d7543323e18 (diff) | |
AutoUpdate: Only set triggered flag if process creation succeeds
Don't set `s_update_triggered` if the updater process fails to be
created. This will allow users in that situation to try to start an
update later without having to restart Dolphin first.
Diffstat (limited to 'Source/Core/UICommon')
| -rw-r--r-- | Source/Core/UICommon/AutoUpdate.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/Source/Core/UICommon/AutoUpdate.cpp b/Source/Core/UICommon/AutoUpdate.cpp index 768f607803..4298382b32 100644 --- a/Source/Core/UICommon/AutoUpdate.cpp +++ b/Source/Core/UICommon/AutoUpdate.cpp @@ -278,7 +278,6 @@ void AutoUpdateChecker::TriggerUpdate(const AutoUpdateChecker::NewVersionInforma return; } - s_update_triggered = true; #ifdef OS_SUPPORTS_UPDATER std::map<std::string, std::string> updater_flags; updater_flags["this-manifest-url"] = info.this_manifest_url; @@ -319,6 +318,7 @@ void AutoUpdateChecker::TriggerUpdate(const AutoUpdateChecker::NewVersionInforma { CloseHandle(pinfo.hThread); CloseHandle(pinfo.hProcess); + s_update_triggered = true; } else { @@ -331,6 +331,10 @@ void AutoUpdateChecker::TriggerUpdate(const AutoUpdateChecker::NewVersionInforma const std::string error = Common::LastStrerrorString(); CriticalAlertFmtT("Could not start updater process: {0}", error); } + else + { + s_update_triggered = true; + } #endif #endif |