Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

1 files changed, 2 insertions, 3 deletions

diff --git a/Source/Core/UICommon/CommandLineParse.cpp b/Source/Core/UICommon/CommandLineParse.cpp
index a37f0f2561..6b855457d8 100644
--- a/Source/Core/UICommon/CommandLineParse.cpp
+++ b/Source/Core/UICommon/CommandLineParse.cpp
@@ -54,9 +54,8 @@ public:
       std::optional<Config::System> system = Config::GetSystemFromName(system_str);
       if (system)
       {
-        m_values.emplace_back(
-            Config::Location{std::move(*system), std::move(section), std::move(key)},
-            std::move(value));
+        m_values.emplace_back(Config::Location{*system, std::move(section), std::move(key)},
+                              std::move(value));
       }
     }
   }