FramebufferManagerBase: Return a std::pair from GetTargetSize

Keeps associated data together. It also eliminates the possibility of out
parameters not being initialized properly. For example, consider the
following example:

-- some FramebufferManager implementation --

void FBMgrImpl::GetTargetSize(u32* width, u32* height) override
{
  // Do nothing
}

-- somewhere else where the function is used --

u32 width, height;
framebuffer_manager_instance->GetTargetSize(&width, &height);

if (texture_width != width) <-- Uninitialized variable usage
{
  ...
}

It makes it much more obvious to spot any initialization issues, because
it requires something to be returned, as opposed to allowing an
implementation to just not do anything.

1 files changed, 4 insertions, 1 deletions

diff --git a/Source/Core/VideoBackends/Null/FramebufferManager.h b/Source/Core/VideoBackends/Null/FramebufferManager.h
index b591bf15fd..d68a4a7d1f 100644
--- a/Source/Core/VideoBackends/Null/FramebufferManager.h
+++ b/Source/Core/VideoBackends/Null/FramebufferManager.h
@@ -4,6 +4,9 @@
 
 #pragma once
 
+#include <utility>
+
+#include "Common/CommonTypes.h"
 #include "VideoCommon/FramebufferManagerBase.h"
 
 class XFBSource : public XFBSourceBase
@@ -23,7 +26,7 @@ public:
     return std::make_unique<XFBSource>();
   }
 
-  void GetTargetSize(unsigned int* width, unsigned int* height) override {}
+  std::pair<u32, u32> GetTargetSize() const override { return std::make_pair(0, 0); }
   void CopyToRealXFB(u32 xfb_addr, u32 fb_stride, u32 fb_height, const EFBRectangle& source_rc,
                      float gamma = 1.0f) override
   {