Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

2 files changed, 9 insertions, 8 deletions

diff --git a/Source/Core/VideoBackends/OGL/OGLPipeline.cpp b/Source/Core/VideoBackends/OGL/OGLPipeline.cpp
index e2c61264c4..caf981338c 100644
--- a/Source/Core/VideoBackends/OGL/OGLPipeline.cpp
+++ b/Source/Core/VideoBackends/OGL/OGLPipeline.cpp
@@ -3,6 +3,8 @@
 
 #include "VideoBackends/OGL/OGLPipeline.h"
 
+#include <utility>
+
 #include "VideoBackends/OGL/OGLShader.h"
 #include "VideoBackends/OGL/OGLVertexManager.h"
 #include "VideoBackends/OGL/ProgramShaderCache.h"
@@ -27,12 +29,12 @@ static GLenum MapToGLPrimitive(PrimitiveType primitive_type)
   }
 }
 OGLPipeline::OGLPipeline(const AbstractPipelineConfig& config, const GLVertexFormat* vertex_format,
-                         const RasterizationState& rasterization_state,
-                         const DepthState& depth_state, const BlendingState& blending_state,
-                         PipelineProgram* program, GLuint gl_primitive)
+                         RasterizationState rasterization_state, DepthState depth_state,
+                         BlendingState blending_state, PipelineProgram* program,
+                         GLuint gl_primitive)
     : AbstractPipeline(config), m_vertex_format(vertex_format),
-      m_rasterization_state(rasterization_state), m_depth_state(depth_state),
-      m_blending_state(blending_state), m_program(program), m_gl_primitive(gl_primitive)
+      m_rasterization_state(std::move(rasterization_state)), m_depth_state(std::move(depth_state)),
+      m_blending_state(std::move(blending_state)), m_program(program), m_gl_primitive(gl_primitive)
 {
 }
 
diff --git a/Source/Core/VideoBackends/OGL/OGLPipeline.h b/Source/Core/VideoBackends/OGL/OGLPipeline.h
index f4dddc681c..0f061d790f 100644
--- a/Source/Core/VideoBackends/OGL/OGLPipeline.h
+++ b/Source/Core/VideoBackends/OGL/OGLPipeline.h
@@ -15,9 +15,8 @@ class OGLPipeline final : public AbstractPipeline
 {
 public:
   explicit OGLPipeline(const AbstractPipelineConfig& config, const GLVertexFormat* vertex_format,
-                       const RasterizationState& rasterization_state, const DepthState& depth_state,
-                       const BlendingState& blending_state, PipelineProgram* program,
-                       GLenum gl_primitive);
+                       RasterizationState rasterization_state, DepthState depth_state,
+                       BlendingState blending_state, PipelineProgram* program, GLenum gl_primitive);
   ~OGLPipeline() override;
 
   const GLVertexFormat* GetVertexFormat() const { return m_vertex_format; }