Replace some [[maybe_unused]] annotations with commented names

Remove the [[maybe_unused]] annotation from various parameters that are
unconditionally unused and comment out their names instead. This makes
it unambiguous that the variables are unused, while making the remaining
[[maybe_unused]] annotations more reliable indicators that those
variables are in fact used in some contexts.

These parameters are mostly in overridden functions where the override
doesn't need that particular variable.

1 files changed, 8 insertions, 7 deletions

diff --git a/Source/Core/VideoBackends/Software/SWGfx.cpp b/Source/Core/VideoBackends/Software/SWGfx.cpp
index ed152aef95..7004c50864 100644
--- a/Source/Core/VideoBackends/Software/SWGfx.cpp
+++ b/Source/Core/VideoBackends/Software/SWGfx.cpp
@@ -35,7 +35,7 @@ bool SWGfx::SupportsUtilityDrawing() const
 }
 
 std::unique_ptr<AbstractTexture> SWGfx::CreateTexture(const TextureConfig& config,
-                                                      [[maybe_unused]] std::string_view name)
+                                                      std::string_view /* name */)
 {
   return std::make_unique<SWTexture>(config);
 }
@@ -77,16 +77,17 @@ public:
 };
 
 std::unique_ptr<AbstractShader>
-SWGfx::CreateShaderFromSource(ShaderStage stage, [[maybe_unused]] std::string_view source,
-                              [[maybe_unused]] VideoCommon::ShaderIncluder* shader_includer,
-                              [[maybe_unused]] std::string_view name)
+SWGfx::CreateShaderFromSource(ShaderStage stage, std::string_view /* source */,
+                              VideoCommon::ShaderIncluder* /* shader_includer */,
+                              std::string_view /* name */)
 {
   return std::make_unique<SWShader>(stage);
 }
 
-std::unique_ptr<AbstractShader>
-SWGfx::CreateShaderFromBinary(ShaderStage stage, const void* data, size_t length,
-                              [[maybe_unused]] std::string_view name)
+std::unique_ptr<AbstractShader> SWGfx::CreateShaderFromBinary(ShaderStage stage,
+                                                              const void* /* data */,
+                                                              size_t /* length */,
+                                                              std::string_view /* name */)
 {
   return std::make_unique<SWShader>(stage);
 }