summaryrefslogtreecommitdiff
path: root/Source/Core/VideoCommon/FramebufferManager.cpp
diff options
context:
space:
mode:
authorJosJuice <josjuice@gmail.com>2021-10-10 17:13:03 +0200
committerJosJuice <josjuice@gmail.com>2021-10-10 17:13:03 +0200
commit97a5a7be24d9ccd4b8b3c5fcd24ff68f67c13a6b (patch)
tree8f9531ed352e52238e739c1a0b0180e10a595b7b /Source/Core/VideoCommon/FramebufferManager.cpp
parent33ffc7aa6666d9b73ad3a45a00354150484f8332 (diff)
Core: Use log variant of PrintCallstack, not print variant
There are two reasons for this. 1. Using Dolphin's logging system lets the user decide whether the printout should go to the terminal, the GUI, or a file. fmt::print always prints to stdout... unless you're on Android, in which case it does nothing at all, because Android disables stdout. 2. The Windows version of Dolphin crashes when you use fmt::print. Yes, really. The crash happens because a call to std::fprint in fmt::v7::detail::fwrite_fully returns that less characters were written than requested, which fmt handles by throwing an exception. (As always, Dolphin does not use exception handling.) I'm not sure why std::fprint is doing this, but since switching away from using fmt::print is a good idea due to the previous point anyway, I'd say it's best to just switch.
Diffstat (limited to 'Source/Core/VideoCommon/FramebufferManager.cpp')
0 files changed, 0 insertions, 0 deletions