summaryrefslogtreecommitdiff
path: root/Source/Core/VideoCommon/GeometryShaderGen.cpp
diff options
context:
space:
mode:
authorDentomologist <dentomologist@gmail.com>2022-07-07 17:00:21 -0700
committerDentomologist <dentomologist@gmail.com>2022-07-08 00:25:55 -0700
commite1e0f42b37dd7f2343b9df99222f32ae56963456 (patch)
treefff99b6ca4dc8c62b537acc0e4abeb2102984db5 /Source/Core/VideoCommon/GeometryShaderGen.cpp
parent71541c13242ef36e49ee7974d792a9e887c405df (diff)
VideoCommon: Fix D3D shader warning X3557 (single iteration loop)
Fix warning "loop only executes for 1 iteration(s), forcing loop to unroll" when vertex_in == 1
Diffstat (limited to 'Source/Core/VideoCommon/GeometryShaderGen.cpp')
-rw-r--r--Source/Core/VideoCommon/GeometryShaderGen.cpp10
1 files changed, 8 insertions, 2 deletions
diff --git a/Source/Core/VideoCommon/GeometryShaderGen.cpp b/Source/Core/VideoCommon/GeometryShaderGen.cpp
index 150354e4f3..b9ec0786b2 100644
--- a/Source/Core/VideoCommon/GeometryShaderGen.cpp
+++ b/Source/Core/VideoCommon/GeometryShaderGen.cpp
@@ -216,7 +216,11 @@ ShaderCode GenerateGeometryShaderCode(APIType api_type, const ShaderHostConfig&
if (wireframe)
out.Write("\tVS_OUTPUT first;\n");
- out.Write("\tfor (int i = 0; i < {}; ++i) {{\n", vertex_in);
+ // Avoid D3D warning about forced unrolling of single-iteration loop
+ if (vertex_in > 1)
+ out.Write("\tfor (int i = 0; i < {}; ++i) {{\n", vertex_in);
+ else
+ out.Write("\tint i = 0;\n");
if (api_type == APIType::OpenGL || api_type == APIType::Vulkan)
{
@@ -307,7 +311,9 @@ ShaderCode GenerateGeometryShaderCode(APIType api_type, const ShaderHostConfig&
EmitVertex(out, host_config, uid_data, "f", api_type, wireframe, stereo, true);
}
- out.Write("\t}}\n");
+ // Only close loop if previous code was in one (See D3D warning above)
+ if (vertex_in > 1)
+ out.Write("\t}}\n");
EndPrimitive(out, host_config, uid_data, api_type, wireframe, stereo);