Merge pull request #12532 from lioncash/json

GraphicsMod/ShaderAsset: Lessen object churn a little bit

1 files changed, 6 insertions, 6 deletions

diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsTargetGroup.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsTargetGroup.cpp
index f02a047339..3ac1b108cd 100644
--- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsTargetGroup.cpp
+++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsTargetGroup.cpp
@@ -12,10 +12,10 @@ void GraphicsTargetGroupConfig::SerializeToConfig(picojson::object& json_obj) co
   {
     picojson::object serialized_target;
     SerializeTargetToConfig(serialized_target, target);
-    serialized_targets.push_back(picojson::value{serialized_target});
+    serialized_targets.emplace_back(std::move(serialized_target));
   }
-  json_obj["targets"] = picojson::value{serialized_targets};
-  json_obj["name"] = picojson::value{m_name};
+  json_obj.emplace("targets", std::move(serialized_targets));
+  json_obj.emplace("name", m_name);
 }
 
 bool GraphicsTargetGroupConfig::DeserializeFromConfig(const picojson::object& obj)
@@ -72,9 +72,9 @@ void GraphicsTargetGroupConfig::SerializeToProfile(picojson::object* obj) const
   {
     picojson::object serialized_target;
     SerializeTargetToProfile(&serialized_target, target);
-    serialized_targets.push_back(picojson::value{serialized_target});
+    serialized_targets.emplace_back(std::move(serialized_target));
   }
-  json_obj["targets"] = picojson::value{serialized_targets};
+  json_obj.emplace("targets", std::move(serialized_targets));
 }
 
 void GraphicsTargetGroupConfig::DeserializeFromProfile(const picojson::object& obj)
@@ -83,7 +83,7 @@ void GraphicsTargetGroupConfig::DeserializeFromProfile(const picojson::object& o
   {
     if (it->second.is<picojson::array>())
     {
-      auto serialized_targets = it->second.get<picojson::array>();
+      const auto& serialized_targets = it->second.get<picojson::array>();
       if (serialized_targets.size() != m_targets.size())
         return;