Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

1 files changed, 12 insertions, 13 deletions

diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp
index 5f9cf48d52..c49b655804 100644
--- a/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp
+++ b/Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp
@@ -247,23 +247,22 @@ void GraphicsModManager::Load(const GraphicsModGroupConfig& config)
     }
   }
 
+  const auto create_action =
+      [filesystem_library = std::move(filesystem_library)](
+          const std::string_view& action_name, const picojson::value& json_data,
+          GraphicsModConfig mod_config) -> std::unique_ptr<GraphicsModAction> {
+    auto action = GraphicsModActionFactory::Create(action_name, json_data, filesystem_library);
+    if (action == nullptr)
+    {
+      return nullptr;
+    }
+    return std::make_unique<DecoratedAction>(std::move(action), std::move(mod_config));
+  };
+
   for (const auto& mod : mods)
   {
     for (const GraphicsModFeatureConfig& feature : mod.m_features)
     {
-      const auto create_action =
-          [filesystem_library](const std::string_view& action_name,
-                               const picojson::value& json_data,
-                               GraphicsModConfig mod_config) -> std::unique_ptr<GraphicsModAction> {
-        auto action =
-            GraphicsModActionFactory::Create(action_name, json_data, std::move(filesystem_library));
-        if (action == nullptr)
-        {
-          return nullptr;
-        }
-        return std::make_unique<DecoratedAction>(std::move(action), std::move(mod_config));
-      };
-
       const auto internal_group = fmt::format("{}.{}", mod.m_title, feature.m_group);
 
       const auto add_target = [&](const GraphicsTargetConfig& target) {