diff options
| author | Lioncash <mai.iam2048@gmail.com> | 2024-01-24 22:40:03 -0500 |
|---|---|---|
| committer | Lioncash <mai.iam2048@gmail.com> | 2024-01-24 22:40:05 -0500 |
| commit | 0327b11e0bec1b591c2a6f7e688be8e30170c1bd (patch) | |
| tree | c6ee91dfe448d99b2a5dd2701f73f2f2715f1fc3 /Source/Core/VideoCommon/GraphicsModSystem | |
| parent | e3e20df185ef5af7d2060ad2e7ea30c3799e8dfe (diff) | |
GraphicsModGroup: Reduce object churn
We can emplace and move to avoid doing object copies.
Diffstat (limited to 'Source/Core/VideoCommon/GraphicsModSystem')
| -rw-r--r-- | Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp | 6 | ||||
| -rw-r--r-- | Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp index 40685dff1b..d61cfb384e 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp +++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.cpp @@ -18,7 +18,7 @@ #include "VideoCommon/GraphicsModSystem/Constants.h" #include "VideoCommon/HiresTextures.h" -GraphicsModGroupConfig::GraphicsModGroupConfig(const std::string& game_id) : m_game_id(game_id) +GraphicsModGroupConfig::GraphicsModGroupConfig(std::string game_id) : m_game_id(std::move(game_id)) { } @@ -145,9 +145,9 @@ void GraphicsModGroupConfig::Save() const { picojson::object serialized_mod; mod.SerializeToProfile(&serialized_mod); - serialized_mods.push_back(picojson::value{serialized_mod}); + serialized_mods.emplace_back(std::move(serialized_mod)); } - serialized_root["mods"] = picojson::value{serialized_mods}; + serialized_root.emplace("mods", std::move(serialized_mods)); const auto output = picojson::value{serialized_root}.serialize(true); json_stream << output; diff --git a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h index 721c8e5c2c..fb24798517 100644 --- a/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h +++ b/Source/Core/VideoCommon/GraphicsModSystem/Config/GraphicsModGroup.h @@ -16,7 +16,7 @@ struct GraphicsModConfig; class GraphicsModGroupConfig { public: - explicit GraphicsModGroupConfig(const std::string& game_id); + explicit GraphicsModGroupConfig(std::string game_id); ~GraphicsModGroupConfig(); GraphicsModGroupConfig(const GraphicsModGroupConfig&); |
