Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

1 files changed, 2 insertions, 2 deletions

diff --git a/Source/Core/VideoCommon/OnScreenDisplay.cpp b/Source/Core/VideoCommon/OnScreenDisplay.cpp
index 6f42879c34..8ab5463d3d 100644
--- a/Source/Core/VideoCommon/OnScreenDisplay.cpp
+++ b/Source/Core/VideoCommon/OnScreenDisplay.cpp
@@ -142,14 +142,14 @@ void AddTypedMessage(MessageType type, std::string message, u32 ms, u32 argb,
   for (auto it = range.first; it != range.second; ++it)
     it->second.should_discard = true;
 
-  s_messages.emplace(type, Message(std::move(message), ms, argb, std::move(icon)));
+  s_messages.emplace(type, Message(std::move(message), ms, argb, icon));
 }
 
 void AddMessage(std::string message, u32 ms, u32 argb,
                 const VideoCommon::CustomTextureData::ArraySlice::Level* icon)
 {
   std::lock_guard lock{s_messages_mutex};
-  s_messages.emplace(MessageType::Typeless, Message(std::move(message), ms, argb, std::move(icon)));
+  s_messages.emplace(MessageType::Typeless, Message(std::move(message), ms, argb, icon));
 }
 
 void DrawMessages()