AchievementManager: Make GetInstance() return a reference

The internal static member will always have a valid lifetime. Makes this
consistent with other instance based objects in our code.

1 files changed, 3 insertions, 4 deletions

diff --git a/Source/Core/VideoCommon/OnScreenUI.cpp b/Source/Core/VideoCommon/OnScreenUI.cpp
index 11953b2f4c..254ff6f2bb 100644
--- a/Source/Core/VideoCommon/OnScreenUI.cpp
+++ b/Source/Core/VideoCommon/OnScreenUI.cpp
@@ -330,10 +330,9 @@ void OnScreenUI::DrawDebugText()
 #ifdef USE_RETRO_ACHIEVEMENTS
 void OnScreenUI::DrawChallenges()
 {
-  std::lock_guard lg{*AchievementManager::GetInstance()->GetLock()};
-  const AchievementManager::NamedIconMap& challenge_icons =
-      AchievementManager::GetInstance()->GetChallengeIcons();
-  if (challenge_icons.size() == 0)
+  std::lock_guard lg{*AchievementManager::GetInstance().GetLock()};
+  const auto& challenge_icons = AchievementManager::GetInstance().GetChallengeIcons();
+  if (challenge_icons.empty())
     return;
 
   const std::string window_name = "Challenges";