summaryrefslogtreecommitdiff
path: root/Source/Core/VideoCommon/RenderBase.cpp
diff options
context:
space:
mode:
authorScott Mansell <phiren@gmail.com>2016-01-08 13:31:48 +1300
committerScott Mansell <phiren@gmail.com>2016-01-08 13:31:48 +1300
commit9c0dae47cad1923fbc6abfc2aa5ba0969828b64d (patch)
tree2fe23c65ded7a665c6cbb09c9383443cd446a66e /Source/Core/VideoCommon/RenderBase.cpp
parentdd1192b7092a005ba0ed2f588c0654d29043b33a (diff)
Normalize aspect ratio calculations to 4:3
Video Interface simply isn't aware about widescreen. Instead, the render class can multiply by 1.3333333 to get the 16:9 aspect ratio.
Diffstat (limited to 'Source/Core/VideoCommon/RenderBase.cpp')
-rw-r--r--Source/Core/VideoCommon/RenderBase.cpp38
1 files changed, 13 insertions, 25 deletions
diff --git a/Source/Core/VideoCommon/RenderBase.cpp b/Source/Core/VideoCommon/RenderBase.cpp
index c52263843f..be1b774d3f 100644
--- a/Source/Core/VideoCommon/RenderBase.cpp
+++ b/Source/Core/VideoCommon/RenderBase.cpp
@@ -80,6 +80,7 @@ unsigned int Renderer::efb_scale_numeratorY = 1;
unsigned int Renderer::efb_scale_denominatorX = 1;
unsigned int Renderer::efb_scale_denominatorY = 1;
+static float AspectToWidescreen(float aspect) { return aspect * ((16.0f / 9.0f) / (4.0f / 3.0f)); }
Renderer::Renderer()
: frame_data()
@@ -431,7 +432,9 @@ void Renderer::UpdateDrawRectangle(int backbuffer_width, int backbuffer_height)
// Don't know if there is a better place for this code so there isn't a 1 frame delay
if (g_ActiveConfig.bWidescreenHack)
{
- float source_aspect = VideoInterface::GetAspectRatio(Core::g_aspect_wide);
+ float source_aspect = VideoInterface::GetAspectRatio();
+ if (Core::g_aspect_wide)
+ source_aspect = AspectToWidescreen(source_aspect);
float target_aspect;
switch (g_ActiveConfig.iAspectRatio)
@@ -440,10 +443,10 @@ void Renderer::UpdateDrawRectangle(int backbuffer_width, int backbuffer_height)
target_aspect = WinWidth / WinHeight;
break;
case ASPECT_ANALOG:
- target_aspect = VideoInterface::GetAspectRatio(false);
+ target_aspect = VideoInterface::GetAspectRatio();
break;
case ASPECT_ANALOG_WIDE:
- target_aspect = VideoInterface::GetAspectRatio(true);
+ target_aspect = AspectToWidescreen(VideoInterface::GetAspectRatio());
break;
default:
// ASPECT_AUTO
@@ -476,17 +479,13 @@ void Renderer::UpdateDrawRectangle(int backbuffer_width, int backbuffer_height)
// The rendering window aspect ratio as a proportion of the 4:3 or 16:9 ratio
float Ratio;
- switch (g_ActiveConfig.iAspectRatio)
+ if (g_ActiveConfig.iAspectRatio == ASPECT_ANALOG_WIDE || (g_ActiveConfig.iAspectRatio != ASPECT_ANALOG && Core::g_aspect_wide))
{
- case ASPECT_ANALOG_WIDE:
- Ratio = (WinWidth / WinHeight) / VideoInterface::GetAspectRatio(true);
- break;
- case ASPECT_ANALOG:
- Ratio = (WinWidth / WinHeight) / VideoInterface::GetAspectRatio(false);
- break;
- default:
- Ratio = (WinWidth / WinHeight) / VideoInterface::GetAspectRatio(Core::g_aspect_wide);
- break;
+ Ratio = (WinWidth / WinHeight) / AspectToWidescreen(VideoInterface::GetAspectRatio());
+ }
+ else
+ {
+ Ratio = (WinWidth / WinHeight) / VideoInterface::GetAspectRatio();
}
if (g_ActiveConfig.iAspectRatio != ASPECT_STRETCH)
@@ -512,18 +511,7 @@ void Renderer::UpdateDrawRectangle(int backbuffer_width, int backbuffer_height)
// ------------------
if (g_ActiveConfig.iAspectRatio != ASPECT_STRETCH && g_ActiveConfig.bCrop)
{
- switch (g_ActiveConfig.iAspectRatio)
- {
- case ASPECT_ANALOG_WIDE:
- Ratio = (16.0f / 9.0f) / VideoInterface::GetAspectRatio(true);
- break;
- case ASPECT_ANALOG:
- Ratio = (4.0f / 3.0f) / VideoInterface::GetAspectRatio(false);
- break;
- default:
- Ratio = (!Core::g_aspect_wide ? (4.0f / 3.0f) : (16.0f / 9.0f)) / VideoInterface::GetAspectRatio(Core::g_aspect_wide);
- break;
- }
+ Ratio = (4.0f / 3.0f) / VideoInterface::GetAspectRatio();
if (Ratio <= 1.0f)
{
Ratio = 1.0f / Ratio;