diff options
| author | comex <comexk@gmail.com> | 2014-03-27 23:52:27 -0400 |
|---|---|---|
| committer | comex <comexk@gmail.com> | 2014-03-30 01:40:06 -0400 |
| commit | b5654a2464b02dc0bc8177d75db24236923e6ad2 (patch) | |
| tree | 9974bdd19b575596165cdc4f9e1d8ae27a3b4c62 /Source/Core/VideoCommon/RenderBase.cpp | |
| parent | 9b8296d5ab2f8d57ff393d802b24c2e344d1cd39 (diff) | |
Don't cast -1 to enum to represent a missing value.
This is undefined behavior in C++, and a clang warning suggests it is
actually producing bad code as a result:
../Source/Core/VideoCommon/BPFunctions.cpp:164:45: warning: comparison of constant 4294967295 with expression of type 'PEControl::PixelFormat' is always false [-Wtautological-constant-out-of-range-compare]
if (new_format == old_format || old_format == (unsigned int)-1)
Diffstat (limited to 'Source/Core/VideoCommon/RenderBase.cpp')
| -rw-r--r-- | Source/Core/VideoCommon/RenderBase.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/Core/VideoCommon/RenderBase.cpp b/Source/Core/VideoCommon/RenderBase.cpp index 12dc7b4bfc..8b42d1c23b 100644 --- a/Source/Core/VideoCommon/RenderBase.cpp +++ b/Source/Core/VideoCommon/RenderBase.cpp @@ -64,7 +64,7 @@ int Renderer::s_LastEFBScale; bool Renderer::s_skipSwap; bool Renderer::XFBWrited; -PEControl::PixelFormat Renderer::prev_efb_format = (PEControl::PixelFormat)-1; +PEControl::PixelFormat Renderer::prev_efb_format = PEControl::INVALID_FMT; unsigned int Renderer::efb_scale_numeratorX = 1; unsigned int Renderer::efb_scale_numeratorY = 1; unsigned int Renderer::efb_scale_denominatorX = 1; @@ -89,7 +89,7 @@ Renderer::Renderer() Renderer::~Renderer() { // invalidate previous efb format - prev_efb_format = (PEControl::PixelFormat)-1; + prev_efb_format = PEControl::INVALID_FMT; efb_scale_numeratorX = efb_scale_numeratorY = efb_scale_denominatorX = efb_scale_denominatorY = 1; |