Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.

1 files changed, 3 insertions, 2 deletions

diff --git a/Source/Core/VideoCommon/ShaderCompileUtils.cpp b/Source/Core/VideoCommon/ShaderCompileUtils.cpp
index 297d86ea92..ee4adbf46e 100644
--- a/Source/Core/VideoCommon/ShaderCompileUtils.cpp
+++ b/Source/Core/VideoCommon/ShaderCompileUtils.cpp
@@ -4,14 +4,15 @@
 #include "VideoCommon/ShaderCompileUtils.h"
 
 #include <ranges>
+#include <utility>
 
 #include "Common/FileUtil.h"
 #include "Common/StringUtil.h"
 
 namespace VideoCommon
 {
-ShaderIncluder::ShaderIncluder(const std::string& user_path, const std::string& system_path)
-    : m_root_user_path(user_path), m_root_system_path(system_path)
+ShaderIncluder::ShaderIncluder(std::string user_path, std::string system_path)
+    : m_root_user_path(std::move(user_path)), m_root_system_path(std::move(system_path))
 {
 }