diff options
| author | Emmanuel Gil Peyrot <emmanuel.peyrot@collabora.com> | 2017-08-07 20:12:50 +0200 |
|---|---|---|
| committer | Emmanuel Gil Peyrot <emmanuel.peyrot@collabora.com> | 2017-08-07 20:20:36 +0200 |
| commit | 1b32751367faba6cf88a5b6572adeeebf905ad9d (patch) | |
| tree | 9c32cd859e6023a6eaa19ba8d1ea2c36361c32ec /Source/Core/VideoCommon/TextureConversionShader.cpp | |
| parent | 1385444d86a66588c7f2db784056128c4e59cf6c (diff) | |
VideoCommon: Round values in swizzlers.
This was breaking Metroid Prime 2: Echoes’s scanner in some rooms, such
as the one in https://fifoci.dolphin-emu.org/dff/mp2-scanner/
It was found on Ivy Bridge on Mesa, the alpha value read back from the
EFB was off-by-4 in multiple objects, which was a conversion error
because int4() is equivalent to floor() and the value wasn’t always
higher.
Diffstat (limited to 'Source/Core/VideoCommon/TextureConversionShader.cpp')
| -rw-r--r-- | Source/Core/VideoCommon/TextureConversionShader.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/Core/VideoCommon/TextureConversionShader.cpp b/Source/Core/VideoCommon/TextureConversionShader.cpp index ab1b284b78..4bd243ee27 100644 --- a/Source/Core/VideoCommon/TextureConversionShader.cpp +++ b/Source/Core/VideoCommon/TextureConversionShader.cpp @@ -74,13 +74,13 @@ static void WriteSwizzler(char*& p, EFBCopyFormat format, APIType ApiType) WRITE(p, "float4 RGBA8ToRGBA6(float4 src)\n"); WRITE(p, "{\n"); - WRITE(p, " int4 val = int4(src * 255.0) >> 2;\n"); + WRITE(p, " int4 val = int4(roundEven(src * 255.0)) >> 2;\n"); WRITE(p, " return float4(val) / 63.0;\n"); WRITE(p, "}\n"); WRITE(p, "float4 RGBA8ToRGB565(float4 src)\n"); WRITE(p, "{\n"); - WRITE(p, " int4 val = int4(src * 255.0);\n"); + WRITE(p, " int4 val = int4(roundEven(src * 255.0));\n"); WRITE(p, " val = int4(val.r >> 3, val.g >> 2, val.b >> 3, 1);\n"); WRITE(p, " return float4(val) / float4(31.0, 63.0, 31.0, 1.0);\n"); WRITE(p, "}\n"); |