summaryrefslogtreecommitdiff
path: root/Source/Core
diff options
context:
space:
mode:
authorTilka <tilkax@gmail.com>2024-01-02 05:06:21 +0000
committerGitHub <noreply@github.com>2024-01-02 05:06:21 +0000
commit48eb8b17ef1eb7227eb200cc3813880a1ba4ae2a (patch)
treeb0b014ee3c83036ba66dd37562ce58165477e0ca /Source/Core
parentfd1a261e7374bc60b0e8c00199ac567468073665 (diff)
parent381c2702f633e7413258bca2637b4301e231542e (diff)
Merge pull request #12475 from Tilka/zelda
DSPHLE/Zelda: fix reverb volume being multiplied by current volume twice
Diffstat (limited to 'Source/Core')
-rw-r--r--Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp b/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
index c6d2fdb907..80b7ac72b9 100644
--- a/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
+++ b/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
@@ -1217,11 +1217,9 @@ void ZeldaAudioRenderer::AddVoice(u16 voice_id)
// Compute reverb volume and ramp deltas.
s16 reverb_volumes[4], reverb_volume_deltas[4];
- s16 reverb_volume_factor =
- (vpb.dolby_volume_current * vpb.dolby_reverb_factor) >> (shift_factor - 1);
for (size_t i = 0; i < 4; ++i)
{
- reverb_volumes[i] = (quadrant_volumes[i] * reverb_volume_factor) >> shift_factor;
+ reverb_volumes[i] = (quadrant_volumes[i] * vpb.dolby_reverb_factor) >> shift_factor;
reverb_volume_deltas[i] = (volume_deltas[i] * vpb.dolby_reverb_factor) >> shift_factor;
}