diff options
| author | jmlee337 <jmlee337@gmail.com> | 2023-07-13 01:15:12 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-13 01:15:12 -0700 |
| commit | 550b9782e140e244575b0b6bee877ce1700ef733 (patch) | |
| tree | 199f5e966579d2fb35ef6d143690977dae5cec21 /Source/Core | |
| parent | 7f40c6f2f86cb3f77b155240df0e512dfe1eef29 (diff) | |
Do not try portmapping when using traversal server
using portmapping with hosting while using traversal server (which is possible by checking the option while under "direct connect" and flipping back to traversal server) causes dolphin to request a mapping to external port 0.
In UPnP a mapping to external port 0 is actually the wildcard, which means that connection requests on all
external ports (that are not otherwise mapped) will be forwarded to the client.
Additionally it seems like using port mapping with traversal server is probably not expected behavior, as the option checkbox disappears when traversal server is used.
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/Core/NetPlayServer.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/Core/Core/NetPlayServer.cpp b/Source/Core/Core/NetPlayServer.cpp index 5452d9e80f..7c49d7b1da 100644 --- a/Source/Core/Core/NetPlayServer.cpp +++ b/Source/Core/Core/NetPlayServer.cpp @@ -169,7 +169,7 @@ NetPlayServer::NetPlayServer(const u16 port, const bool forward_port, NetPlayUI* m_chunked_data_thread = std::thread(&NetPlayServer::ChunkedDataThreadFunc, this); #ifdef USE_UPNP - if (forward_port) + if (forward_port && !traversal_config.use_traversal) Common::UPnP::TryPortmapping(port); #endif } |