diff options
| author | JosJuice <josjuice@gmail.com> | 2018-03-31 14:52:21 +0200 |
|---|---|---|
| committer | JosJuice <josjuice@gmail.com> | 2018-03-31 14:52:21 +0200 |
| commit | 5847e213af7cff73671ae114a4e8f99a8ab69745 (patch) | |
| tree | c341d7a489c3d646d303037d5f386366c6c8474c /Source/Core | |
| parent | a7ba69e16a7c0a7725d35f6c5bfe66db01aaa6a9 (diff) | |
Clean up the end of GameFile::BannerChanged
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/UICommon/GameFile.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/Source/Core/UICommon/GameFile.cpp b/Source/Core/UICommon/GameFile.cpp index c2d9624c43..6223b1fb6e 100644 --- a/Source/Core/UICommon/GameFile.cpp +++ b/Source/Core/UICommon/GameFile.cpp @@ -226,12 +226,9 @@ bool GameFile::BannerChanged() DiscIO::WiiSaveBanner(m_title_id) .GetBanner(&m_pending.volume_banner.width, &m_pending.volume_banner.height); - if (m_pending.volume_banner.buffer.empty()) - return false; - - // We only reach here if m_volume_banner was empty, so we can always return true - // without needing any extra check to know whether the banners are different - return true; + // We only reach here if the old banner was empty, so if the new banner isn't empty, + // the new banner is guaranteed to be different from the old banner + return !m_pending.volume_banner.buffer.empty(); } void GameFile::BannerCommit() |
