diff options
| author | Admiral H. Curtiss <pikachu025@gmail.com> | 2026-07-22 12:18:43 +0200 |
|---|---|---|
| committer | OatmealDome <julian@oatmealdome.me> | 2026-08-10 17:50:26 -0400 |
| commit | 6d2e3a1ecc1f2b3b140b650eda9d9be5dc0a92e3 (patch) | |
| tree | b129a1dbd040c04798b74064a65f6ac50fd26745 /Source/Core | |
| parent | b2c4d543dd87e5344516d212ee29d256caa2adf1 (diff) | |
HW/DSPHLE/AXVoice: Prefer BitCastPtr over BitCastToArray in ApplyUpdatesForMs()
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h b/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h index 1655e28074..636c22ce65 100644 --- a/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h +++ b/Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h @@ -59,8 +59,6 @@ PBUpdateData LoadPBUpdates(Memory::MemoryManager& memory, const PB_TYPE& pb) // Apply updates to a PB. void ApplyUpdatesForMs(int curr_ms, PB_TYPE& pb, u16* num_updates, const PBUpdateData& updates) { - auto pb_mem = Common::BitCastToArray<u16>(pb); - u32 start_idx = 0; for (int i = 0; i < curr_ms; ++i) start_idx += num_updates[i]; @@ -76,13 +74,11 @@ void ApplyUpdatesForMs(int curr_ms, PB_TYPE& pb, u16* num_updates, const PBUpdat const u16 update_off = updates[i].pb_offset; const u16 update_val = updates[i].new_value; - if (update_off < pb_mem.size()) - pb_mem[update_off] = update_val; + if (update_off < (sizeof(pb) / sizeof(u16))) + Common::BitCastPtr<u16>(&pb)[update_off] = update_val; } } } - - pb = std::bit_cast<PB_TYPE>(pb_mem); } // Used to pass a large amount of buffers to the mixing function. |