diff options
| author | OatmealDome <julian@oatmealdome.me> | 2021-09-16 23:22:05 -0400 |
|---|---|---|
| committer | OatmealDome <julian@oatmealdome.me> | 2021-09-16 23:32:10 -0400 |
| commit | 7e8f5208fe2cd01277358abdeec622492927eb11 (patch) | |
| tree | dbd3993f513e17dcb9c1ea0c662b6da30cd67f5d /Source/Core | |
| parent | 2d1ec6332b6335107e4e1fbd9c6735840117623e (diff) | |
VulkanContext: Disable subgroup reduction on macOS with AMD GPUs
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/VideoBackends/Vulkan/VulkanContext.cpp | 3 | ||||
| -rw-r--r-- | Source/Core/VideoCommon/DriverDetails.cpp | 2 | ||||
| -rw-r--r-- | Source/Core/VideoCommon/DriverDetails.h | 6 |
3 files changed, 10 insertions, 1 deletions
diff --git a/Source/Core/VideoBackends/Vulkan/VulkanContext.cpp b/Source/Core/VideoBackends/Vulkan/VulkanContext.cpp index 63ad23e7ed..74d51c07df 100644 --- a/Source/Core/VideoBackends/Vulkan/VulkanContext.cpp +++ b/Source/Core/VideoBackends/Vulkan/VulkanContext.cpp @@ -944,7 +944,8 @@ void VulkanContext::PopulateShaderSubgroupSupport() VK_SUBGROUP_FEATURE_BALLOT_BIT; m_supports_shader_subgroup_operations = (subgroup_properties.supportedOperations & required_operations) == required_operations && - subgroup_properties.supportedStages & VK_SHADER_STAGE_FRAGMENT_BIT; + subgroup_properties.supportedStages & VK_SHADER_STAGE_FRAGMENT_BIT && + !DriverDetails::HasBug(DriverDetails::BUG_BROKEN_SUBGROUP_INVOCATION_ID); } bool VulkanContext::SupportsExclusiveFullscreen(const WindowSystemInfo& wsi, VkSurfaceKHR surface) diff --git a/Source/Core/VideoCommon/DriverDetails.cpp b/Source/Core/VideoCommon/DriverDetails.cpp index 3f31a522d0..4b1ce936d0 100644 --- a/Source/Core/VideoCommon/DriverDetails.cpp +++ b/Source/Core/VideoCommon/DriverDetails.cpp @@ -127,6 +127,8 @@ constexpr BugInfo m_known_bugs[] = { -1.0, -1.0, true}, {API_OPENGL, OS_WINDOWS, VENDOR_ATI, DRIVER_ATI, Family::UNKNOWN, BUG_BROKEN_SSBO_FIELD_ATOMICS, -1.0, -1.0, true}, + {API_VULKAN, OS_OSX, VENDOR_ATI, DRIVER_PORTABILITY, Family::UNKNOWN, + BUG_BROKEN_SUBGROUP_INVOCATION_ID, -1.0, -1.0, true}, }; static std::map<Bug, BugInfo> m_bugs; diff --git a/Source/Core/VideoCommon/DriverDetails.h b/Source/Core/VideoCommon/DriverDetails.h index 600c9f3823..6a9927faa3 100644 --- a/Source/Core/VideoCommon/DriverDetails.h +++ b/Source/Core/VideoCommon/DriverDetails.h @@ -305,6 +305,12 @@ enum Bug // Started version: -1 // Ended version: -1 BUG_BROKEN_SSBO_FIELD_ATOMICS, + + // BUG: Accessing gl_SubgroupInvocationID causes the Metal shader compiler to crash. + // Affected devices: AMD (macOS) + // Started version: -1 + // Ended version: -1 + BUG_BROKEN_SUBGROUP_INVOCATION_ID, }; // Initializes our internal vendor, device family, and driver version |