diff options
| author | JosJuice <josjuice@gmail.com> | 2022-09-22 18:09:27 +0200 |
|---|---|---|
| committer | JosJuice <josjuice@gmail.com> | 2022-10-15 17:06:32 +0200 |
| commit | b9aed428e892b11aacd94b603f05fb412bd12274 (patch) | |
| tree | 1451040f0e42a85843d33cffd39c810aa818f91c /Source/Core | |
| parent | 3af74d82a0c32cf171a8c1a3a2aa2547b70df791 (diff) | |
Jit64: Remove breakpoint check from JitAsm.cpp
The breakpoint check in Jit.cpp makes it redundant.
Normally this redundant check doesn't cause any issues, but if you
create a breakpoint and enable logging without breaking, you get two
log messages if the breakpoint is at the beginning of a block. See
https://bugs.dolphin-emu.org/issues/13044.
This is also a tiny performance improvement for when debugging is
active, since we no longer check for breakpoints for blocks that never
had any breakpoints to begin with.
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/Core/PowerPC/Jit64/JitAsm.cpp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/Source/Core/Core/PowerPC/Jit64/JitAsm.cpp b/Source/Core/Core/PowerPC/Jit64/JitAsm.cpp index 1fbdc8306e..46103b56f9 100644 --- a/Source/Core/Core/PowerPC/Jit64/JitAsm.cpp +++ b/Source/Core/Core/PowerPC/Jit64/JitAsm.cpp @@ -92,15 +92,8 @@ void Jit64AsmRoutineManager::Generate() if (enable_debugging) { MOV(64, R(RSCRATCH), ImmPtr(CPU::GetStatePtr())); - TEST(32, MatR(RSCRATCH), Imm32(static_cast<u32>(CPU::State::Stepping))); - FixupBranch notStepping = J_CC(CC_Z); - ABI_PushRegistersAndAdjustStack({}, 0); - ABI_CallFunction(PowerPC::CheckBreakPoints); - ABI_PopRegistersAndAdjustStack({}, 0); - MOV(64, R(RSCRATCH), ImmPtr(CPU::GetStatePtr())); TEST(32, MatR(RSCRATCH), Imm32(0xFFFFFFFF)); dbg_exit = J_CC(CC_NZ, true); - SetJumpTarget(notStepping); } SetJumpTarget(skipToRealDispatch); |