summaryrefslogtreecommitdiff
path: root/Source/Core
diff options
context:
space:
mode:
authorTechjar <tecknojar@gmail.com>2018-06-28 02:12:13 -0400
committerTechjar <tecknojar@gmail.com>2018-07-01 04:42:47 -0400
commitbc15eb2d573ce6988de027e13d5d78511ff23d6d (patch)
tree3c87082c8072abd40826439eaabf8a3af095d394 /Source/Core
parentf5730e1636458db654b62e60a7ec4ad5f85686ba (diff)
Expose arbitrary mipmap detection toggle in UI
Diffstat (limited to 'Source/Core')
-rw-r--r--Source/Core/Core/ConfigLoaders/IsSettingSaveable.cpp3
-rw-r--r--Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.cpp14
-rw-r--r--Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.h1
3 files changed, 15 insertions, 3 deletions
diff --git a/Source/Core/Core/ConfigLoaders/IsSettingSaveable.cpp b/Source/Core/Core/ConfigLoaders/IsSettingSaveable.cpp
index 932a1f03a2..c1a75b04e1 100644
--- a/Source/Core/Core/ConfigLoaders/IsSettingSaveable.cpp
+++ b/Source/Core/Core/ConfigLoaders/IsSettingSaveable.cpp
@@ -90,6 +90,7 @@ bool IsSettingSaveable(const Config::ConfigLocation& config_location)
Config::GFX_ENHANCE_POST_SHADER.location,
Config::GFX_ENHANCE_FORCE_TRUE_COLOR.location,
Config::GFX_ENHANCE_DISABLE_COPY_FILTER.location,
+ Config::GFX_ENHANCE_ARBITRARY_MIPMAP_DETECTION.location,
// Graphics.Stereoscopy
@@ -128,4 +129,4 @@ bool IsSettingSaveable(const Config::ConfigLocation& config_location)
return std::find(s_setting_saveable.begin(), s_setting_saveable.end(), config_location) !=
s_setting_saveable.end();
}
-} // namespace ConfigLoader
+} // namespace ConfigLoaders
diff --git a/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.cpp b/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.cpp
index 98bb94a37e..d15e910c10 100644
--- a/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.cpp
+++ b/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.cpp
@@ -81,6 +81,8 @@ void EnhancementsWidget::CreateWidgets()
new GraphicsBool(tr("Force 24-Bit Color"), Config::GFX_ENHANCE_FORCE_TRUE_COLOR);
m_disable_copy_filter =
new GraphicsBool(tr("Disable Copy Filter"), Config::GFX_ENHANCE_DISABLE_COPY_FILTER);
+ m_arbitrary_mipmap_detection = new GraphicsBool(tr("Arbitrary Mipmap Detection"),
+ Config::GFX_ENHANCE_ARBITRARY_MIPMAP_DETECTION);
enhancements_layout->addWidget(new QLabel(tr("Internal Resolution:")), 0, 0);
enhancements_layout->addWidget(m_ir_combo, 0, 1, 1, -1);
@@ -100,6 +102,7 @@ void EnhancementsWidget::CreateWidgets()
enhancements_layout->addWidget(m_disable_fog, 7, 0);
enhancements_layout->addWidget(m_force_24bit_color, 7, 1);
enhancements_layout->addWidget(m_disable_copy_filter, 8, 0);
+ enhancements_layout->addWidget(m_arbitrary_mipmap_detection, 8, 1);
// Stereoscopy
auto* stereoscopy_box = new QGroupBox(tr("Stereoscopy"));
@@ -336,7 +339,7 @@ void EnhancementsWidget::AddDescriptions()
static const char TR_FORCE_24BIT_DESCRIPTION[] =
QT_TR_NOOP("Forces the game to render the RGB color channels in 24-bit, thereby increasing "
"quality by reducing color banding.\nIt has no impact on performance and causes "
- "few graphical issues.\n\n\nIf unsure, leave this checked.");
+ "few graphical issues.\n\nIf unsure, leave this checked.");
static const char TR_FORCE_TEXTURE_FILTERING_DESCRIPTION[] =
QT_TR_NOOP("Filter all textures, including any that the game explicitly set as "
"unfiltered.\nMay improve quality of certain textures in some games, but will "
@@ -345,7 +348,13 @@ void EnhancementsWidget::AddDescriptions()
QT_TR_NOOP("Disables the blending of adjacent rows when copying the EFB. This is known in "
"some games as \"deflickering\" or \"smoothing\". Disabling the filter has no "
"effect on performance, but may result in a sharper image, and causes few "
- "graphical issues.\n\n\nIf unsure, leave this checked.");
+ "graphical issues.\n\nIf unsure, leave this checked.");
+ static const char TR_ARBITRARY_MIPMAP_DETECTION_DESCRIPTION[] =
+ QT_TR_NOOP("Enables detection of arbitrary mipmaps, which some games use for special "
+ "distance-based effects.\nMay have false positives that result in blurry textures "
+ "at increased internal resolution, such as in games that use very low resolution "
+ "mipmaps.\nDisabling this can also reduce stutter in games that "
+ "frequently load new textures.\n\nIf unsure, leave this checked.");
AddDescription(m_ir_combo, TR_INTERNAL_RESOLUTION_DESCRIPTION);
AddDescription(m_aa_combo, TR_ANTIALIAS_DESCRIPTION);
@@ -358,6 +367,7 @@ void EnhancementsWidget::AddDescriptions()
AddDescription(m_force_24bit_color, TR_FORCE_24BIT_DESCRIPTION);
AddDescription(m_force_texture_filtering, TR_FORCE_TEXTURE_FILTERING_DESCRIPTION);
AddDescription(m_disable_copy_filter, TR_DISABLE_COPY_FILTER_DESCRIPTION);
+ AddDescription(m_arbitrary_mipmap_detection, TR_ARBITRARY_MIPMAP_DETECTION_DESCRIPTION);
AddDescription(m_3d_mode, TR_3D_MODE_DESCRIPTION);
AddDescription(m_3d_depth, TR_3D_DEPTH_DESCRIPTION);
AddDescription(m_3d_convergence, TR_3D_CONVERGENCE_DESCRIPTION);
diff --git a/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.h b/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.h
index ed0b90ea21..6126576378 100644
--- a/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.h
+++ b/Source/Core/DolphinQt2/Config/Graphics/EnhancementsWidget.h
@@ -41,6 +41,7 @@ private:
QCheckBox* m_disable_fog;
QCheckBox* m_force_24bit_color;
QCheckBox* m_disable_copy_filter;
+ QCheckBox* m_arbitrary_mipmap_detection;
// Stereoscopy
QComboBox* m_3d_mode;