diff options
| author | Lioncash <mathew1800@gmail.com> | 2018-08-27 10:17:46 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2018-08-27 10:28:11 -0400 |
| commit | cc2ef5a2c3c4cf08d8f3913eb688372e34626e3d (patch) | |
| tree | 6486918ce472b510f2b4fd32add9c8b6a54969a6 /Source/Core | |
| parent | 25898cfa55e26b5ebc5cf307e47cfaf8896cfc74 (diff) | |
JitArm64/Jit: Don't cast away const within DumpCode()
swap32() has a const u8* overload that swaps the data being pointed to as
if it were a 32-bit word. We can just use that instead. It gets rid of
undefined behavior, as we're not type punning a pointer and dereferencing it,
and gets rid of the need to cast entirely.
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/Core/PowerPC/JitArm64/Jit.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Source/Core/Core/PowerPC/JitArm64/Jit.cpp b/Source/Core/Core/PowerPC/JitArm64/Jit.cpp index 6827d9a29c..3224d27bcf 100644 --- a/Source/Core/Core/PowerPC/JitArm64/Jit.cpp +++ b/Source/Core/Core/PowerPC/JitArm64/Jit.cpp @@ -489,9 +489,9 @@ void JitArm64::WriteExceptionExit(ARM64Reg dest, bool only_external) void JitArm64::DumpCode(const u8* start, const u8* end) { - std::string output = ""; - for (u8* code = (u8*)start; code < end; code += 4) - output += StringFromFormat("%08x", Common::swap32(*(u32*)code)); + std::string output; + for (const u8* code = start; code < end; code += sizeof(u32)) + output += StringFromFormat("%08x", Common::swap32(code)); WARN_LOG(DYNA_REC, "Code dump from %p to %p:\n%s", start, end, output.c_str()); } |
