diff options
| author | Jordan Woyak <jordan.woyak@gmail.com> | 2025-10-21 19:19:13 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-21 19:19:13 -0500 |
| commit | e34ef86be977a9db83f59ebc65f112e983bc4a7f (patch) | |
| tree | a8f844fcf36ead4ef028f32cdfa44aea0ab8e5ee /Source/Core | |
| parent | be131ddc5974dda67e597195437a9e65034853fa (diff) | |
| parent | 8c03702b9c9a0fff6dc9499f90dd18eebb8cad9c (diff) | |
Merge pull request #13947 from JosJuice/i18n-2025-08-17-type
i18n: Improve EditSymbolDialog's symbol vs note handling for translators
Diffstat (limited to 'Source/Core')
| -rw-r--r-- | Source/Core/DolphinQt/Debugger/EditSymbolDialog.cpp | 17 | ||||
| -rw-r--r-- | Source/Core/DolphinQt/Debugger/EditSymbolDialog.h | 2 |
2 files changed, 10 insertions, 9 deletions
diff --git a/Source/Core/DolphinQt/Debugger/EditSymbolDialog.cpp b/Source/Core/DolphinQt/Debugger/EditSymbolDialog.cpp index 1a143b7a4e..fb0746a64e 100644 --- a/Source/Core/DolphinQt/Debugger/EditSymbolDialog.cpp +++ b/Source/Core/DolphinQt/Debugger/EditSymbolDialog.cpp @@ -14,11 +14,10 @@ EditSymbolDialog::EditSymbolDialog(QWidget* parent, const u32 symbol_address, u32* symbol_size, std::string* symbol_name, Type type) - : QDialog(parent), m_symbol_name(symbol_name), m_symbol_size(symbol_size), + : QDialog(parent), m_type(type), m_symbol_name(symbol_name), m_symbol_size(symbol_size), m_symbol_address(symbol_address) { - m_type = type == Type::Symbol ? tr("Symbol") : tr("Note"); - setWindowTitle(tr("Edit %1").arg(m_type)); + setWindowTitle(m_type == Type::Symbol ? tr("Edit Symbol") : tr("Edit Note")); CreateWidgets(); ConnectWidgets(); } @@ -29,12 +28,14 @@ void EditSymbolDialog::CreateWidgets() m_buttons->addButton(tr("Reset"), QDialogButtonBox::ResetRole); m_buttons->addButton(tr("Delete"), QDialogButtonBox::DestructiveRole); - QLabel* info_label = new QLabel(tr("Editing %1 starting at: %2\nWarning: Must save the symbol " - "map for changes to be kept.") - .arg(m_type) - .arg(QString::number(m_symbol_address, 16))); + QLabel* info_label = + // i18n: %1 is an address. %2 is a warning message. + new QLabel((m_type == Type::Symbol ? tr("Editing symbol starting at: %1\n%2") : + tr("Editing note starting at: %1\n%2")) + .arg(QString::number(m_symbol_address, 16)) + .arg(tr("Warning: Must save the symbol map for changes to be kept."))); m_name_edit = new QLineEdit(); - m_name_edit->setPlaceholderText(tr("%1 name").arg(m_type)); + m_name_edit->setPlaceholderText(m_type == Type::Symbol ? tr("Symbol name") : tr("Note name")); auto* size_layout = new QHBoxLayout; // i18n: The address where a symbol ends diff --git a/Source/Core/DolphinQt/Debugger/EditSymbolDialog.h b/Source/Core/DolphinQt/Debugger/EditSymbolDialog.h index c3e3f034e7..004bb9fdbc 100644 --- a/Source/Core/DolphinQt/Debugger/EditSymbolDialog.h +++ b/Source/Core/DolphinQt/Debugger/EditSymbolDialog.h @@ -42,7 +42,7 @@ private: QDialogButtonBox* m_buttons; - QString m_type; + Type m_type; std::string* m_symbol_name; u32* m_symbol_size; const u32 m_symbol_address; |