diff options
| author | Jordan Woyak <jordan.woyak@gmail.com> | 2025-08-25 21:34:13 -0500 |
|---|---|---|
| committer | Jordan Woyak <jordan.woyak@gmail.com> | 2025-08-27 21:24:46 -0500 |
| commit | da546bebb8601192cb7fa8ff30a840a1c43b0e03 (patch) | |
| tree | f110067d282bc31cc28b9a0c9ef494b1e08de5cb /Source/UnitTests/Common/MathUtilTest.cpp | |
| parent | 2b7faeb920da31edb11f01c9a0473f86e4023100 (diff) | |
MathUtil: Simplify SaturatingCast implementation with std::cmp_less/cmp_greater and fix a floating point edge case.
Thanks to Dentomologist for catching the edge case.
Diffstat (limited to 'Source/UnitTests/Common/MathUtilTest.cpp')
| -rw-r--r-- | Source/UnitTests/Common/MathUtilTest.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/Source/UnitTests/Common/MathUtilTest.cpp b/Source/UnitTests/Common/MathUtilTest.cpp index 966f3a4445..c60c19e6a1 100644 --- a/Source/UnitTests/Common/MathUtilTest.cpp +++ b/Source/UnitTests/Common/MathUtilTest.cpp @@ -66,6 +66,13 @@ TEST(MathUtil, SaturatingCast) // 16777217 = 2^24 + 1 is the first integer that cannot be represented correctly with a f32. EXPECT_EQ(16777216, MathUtil::SaturatingCast<s32>(float(16777216))); EXPECT_EQ(16777216, MathUtil::SaturatingCast<s32>(float(16777217))); + + // Note that values in the range [2147483584, 2147483776] have an equivalent float representation. + EXPECT_EQ(std::numeric_limits<s32>::max(), MathUtil::SaturatingCast<s32>(2147483648.f)); + EXPECT_EQ(std::numeric_limits<s32>::min(), MathUtil::SaturatingCast<s32>(-2147483649.f)); + + // Cast from a signed integer type to a smaller signed integer type + EXPECT_EQ(-128, (MathUtil::SaturatingCast<s8, int>(-129))); } TEST(MathUtil, RectangleEquality) |