diff options
| author | JMC47 <JMC4789@gmail.com> | 2023-08-29 17:38:31 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-29 17:38:31 -0400 |
| commit | efa820763a4e3ae55d1b6d253b9b71b09c9595b9 (patch) | |
| tree | 856aad1d8e64e23a656c4d53ff4b69322791e571 /Source/UnitTests/Core/PageFaultTest.cpp | |
| parent | 1b2d0c05077b95e208babc498133f842f9e79784 (diff) | |
| parent | 75a62e116c374ff4d9def30e25b7b23e6f836a91 (diff) | |
Merge pull request #12147 from Dentomologist/pagefaulttest_use_gtest_skip
PageFaultTest: Use GTEST_SKIP instead of early return
Diffstat (limited to 'Source/UnitTests/Core/PageFaultTest.cpp')
| -rw-r--r-- | Source/UnitTests/Core/PageFaultTest.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/Source/UnitTests/Core/PageFaultTest.cpp b/Source/UnitTests/Core/PageFaultTest.cpp index 3f693923e0..fd58e1fb45 100644 --- a/Source/UnitTests/Core/PageFaultTest.cpp +++ b/Source/UnitTests/Core/PageFaultTest.cpp @@ -68,10 +68,8 @@ static void ASAN_DISABLE perform_invalid_access(void* data) TEST(PageFault, PageFault) { if (!EMM::IsExceptionHandlerSupported()) - { - // TODO: Use GTEST_SKIP() instead when GTest is updated to 1.10+ - return; - } + GTEST_SKIP() << "Skipping PageFault test because exception handler is unsupported."; + EMM::InstallExceptionHandler(); void* data = Common::AllocateMemoryPages(PAGE_GRAN); EXPECT_NE(data, nullptr); |
