summaryrefslogtreecommitdiff
path: root/Source
diff options
context:
space:
mode:
authorJosJuice <josjuice@gmail.com>2021-06-26 15:41:23 +0200
committerJosJuice <josjuice@gmail.com>2021-06-26 15:41:23 +0200
commit36798b18e8defed48e2625f011df6c66ee2abaaf (patch)
tree31e38680a8ce9dc9d2c3e867913707e182503e62 /Source
parentc77a5f7e3246398aeb1d520d7bbc0bfdf5787754 (diff)
JitArm64: Improve fctiwzx constant generation in double case
If we already have to use a GPR, we might as well take advantage of the nice immediate encodings provided by GPR ORR. This is faster, smaller, and saves a register.
Diffstat (limited to 'Source')
-rw-r--r--Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp20
1 files changed, 11 insertions, 9 deletions
diff --git a/Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp b/Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
index b5f9e498aa..6d0bd011c4 100644
--- a/Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
+++ b/Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
@@ -480,27 +480,29 @@ void JitArm64::fctiwzx(UGeckoInstruction inst)
const ARM64Reg VB = fpr.R(b, single ? RegType::LowerPairSingle : RegType::LowerPair);
const ARM64Reg VD = fpr.RW(d, RegType::LowerPair);
- const ARM64Reg V0 = fpr.GetReg();
-
- // Generate 0xFFF8000000000000ULL
- m_float_emit.MOVI(64, EncodeRegToDouble(V0), 0xFFFF000000000000ULL);
- m_float_emit.BIC(16, EncodeRegToDouble(V0), 0x7);
-
if (single)
{
+ const ARM64Reg V0 = fpr.GetReg();
+
+ // Generate 0xFFF8'0000'0000'0000ULL
+ m_float_emit.MOVI(64, EncodeRegToDouble(V0), 0xFFFF'0000'0000'0000ULL);
+ m_float_emit.BIC(16, EncodeRegToDouble(V0), 0x7);
+
m_float_emit.FCVTS(EncodeRegToSingle(VD), EncodeRegToSingle(VB), RoundingMode::Z);
+ m_float_emit.ORR(EncodeRegToDouble(VD), EncodeRegToDouble(VD), EncodeRegToDouble(V0));
+
+ fpr.Unlock(V0);
}
else
{
const ARM64Reg WA = gpr.GetReg();
m_float_emit.FCVTS(WA, EncodeRegToDouble(VB), RoundingMode::Z);
- m_float_emit.FMOV(EncodeRegToSingle(VD), WA);
+ ORRI2R(EncodeRegTo64(WA), EncodeRegTo64(WA), 0xFFF8'0000'0000'0000ULL);
+ m_float_emit.FMOV(EncodeRegToDouble(VD), EncodeRegTo64(WA));
gpr.Unlock(WA);
}
- m_float_emit.ORR(EncodeRegToDouble(VD), EncodeRegToDouble(VD), EncodeRegToDouble(V0));
- fpr.Unlock(V0);
ASSERT_MSG(DYNA_REC, b == d || single == fpr.IsSingle(b, true),
"Register allocation turned singles into doubles in the middle of fctiwzx");