summaryrefslogtreecommitdiff
path: root/Source
diff options
context:
space:
mode:
authorLioncash <mathew1800@gmail.com>2019-05-28 17:40:24 -0400
committerLioncash <mathew1800@gmail.com>2019-05-28 17:40:28 -0400
commit4d2e0c7b480eea2ec78377004ec6911c83abbfff (patch)
tree7a860cce6f56306ec03d753297c0750098ba1a27 /Source
parent992c8bfc4e2394ad5786f5116f5e62ae595b5c44 (diff)
UICommon/ResourcePack/Manager: Resolve use-after-move in Add()
The pack is already has its validity checked at the beginning of the function, so we don't need to check this again after inserting it. Also resolves a use-after-move case.
Diffstat (limited to 'Source')
-rw-r--r--Source/Core/UICommon/ResourcePack/Manager.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/Core/UICommon/ResourcePack/Manager.cpp b/Source/Core/UICommon/ResourcePack/Manager.cpp
index 4977f09523..0d2327e56e 100644
--- a/Source/Core/UICommon/ResourcePack/Manager.cpp
+++ b/Source/Core/UICommon/ResourcePack/Manager.cpp
@@ -128,7 +128,7 @@ bool Add(const std::string& path, int offset)
packs.insert(packs.begin() + offset, std::move(pack));
- return pack.IsValid();
+ return true;
}
bool Remove(ResourcePack& pack)