summaryrefslogtreecommitdiff
path: root/Source
diff options
context:
space:
mode:
authorDr. Dystopia <jonis9898@hotmail.com>2025-05-16 08:28:06 +0200
committerDr. Dystopia <jonis9898@hotmail.com>2025-05-16 08:28:06 +0200
commit58c79bc5eda7249710f4d7045cfcf4a989227d51 (patch)
tree89ba64c462fc9c1421d8e8a4b33c345639c13e61 /Source
parentc211efd84a5ec159e6cf82498cf01c0ac05b94c0 (diff)
UnitTests/PowerPC: Use constant functions, variables and parameters
Diffstat (limited to 'Source')
-rw-r--r--Source/UnitTests/Core/PowerPC/DivUtilsTest.cpp22
-rw-r--r--Source/UnitTests/Core/PowerPC/Jit64Common/ConvertDoubleToSingle.cpp2
-rw-r--r--Source/UnitTests/Core/PowerPC/Jit64Common/Frsqrte.cpp4
-rw-r--r--Source/UnitTests/Core/PowerPC/JitArm64/ConvertSingleDouble.cpp8
-rw-r--r--Source/UnitTests/Core/PowerPC/JitArm64/Frsqrte.cpp2
5 files changed, 19 insertions, 19 deletions
diff --git a/Source/UnitTests/Core/PowerPC/DivUtilsTest.cpp b/Source/UnitTests/Core/PowerPC/DivUtilsTest.cpp
index b218745849..d015bc046a 100644
--- a/Source/UnitTests/Core/PowerPC/DivUtilsTest.cpp
+++ b/Source/UnitTests/Core/PowerPC/DivUtilsTest.cpp
@@ -9,12 +9,12 @@ using namespace JitCommon;
TEST(DivUtils, Signed)
{
- SignedMagic m3 = SignedDivisionConstants(3);
- SignedMagic m5 = SignedDivisionConstants(5);
- SignedMagic m7 = SignedDivisionConstants(7);
- SignedMagic minus3 = SignedDivisionConstants(-3);
- SignedMagic minus5 = SignedDivisionConstants(-5);
- SignedMagic minus7 = SignedDivisionConstants(-7);
+ const SignedMagic m3 = SignedDivisionConstants(3);
+ const SignedMagic m5 = SignedDivisionConstants(5);
+ const SignedMagic m7 = SignedDivisionConstants(7);
+ const SignedMagic minus3 = SignedDivisionConstants(-3);
+ const SignedMagic minus5 = SignedDivisionConstants(-5);
+ const SignedMagic minus7 = SignedDivisionConstants(-7);
EXPECT_EQ(0x55555556, m3.multiplier);
EXPECT_EQ(0, m3.shift);
@@ -33,11 +33,11 @@ TEST(DivUtils, Signed)
TEST(DivUtils, Unsigned)
{
- UnsignedMagic m3 = UnsignedDivisionConstants(3);
- UnsignedMagic m5 = UnsignedDivisionConstants(5);
- UnsignedMagic m7 = UnsignedDivisionConstants(7);
- UnsignedMagic m9 = UnsignedDivisionConstants(9);
- UnsignedMagic m19 = UnsignedDivisionConstants(19);
+ const UnsignedMagic m3 = UnsignedDivisionConstants(3);
+ const UnsignedMagic m5 = UnsignedDivisionConstants(5);
+ const UnsignedMagic m7 = UnsignedDivisionConstants(7);
+ const UnsignedMagic m9 = UnsignedDivisionConstants(9);
+ const UnsignedMagic m19 = UnsignedDivisionConstants(19);
EXPECT_EQ(0xAAAAAAABU, m3.multiplier);
EXPECT_EQ(1, m3.shift);
diff --git a/Source/UnitTests/Core/PowerPC/Jit64Common/ConvertDoubleToSingle.cpp b/Source/UnitTests/Core/PowerPC/Jit64Common/ConvertDoubleToSingle.cpp
index 09c0f30169..05c80854b2 100644
--- a/Source/UnitTests/Core/PowerPC/Jit64Common/ConvertDoubleToSingle.cpp
+++ b/Source/UnitTests/Core/PowerPC/Jit64Common/ConvertDoubleToSingle.cpp
@@ -57,7 +57,7 @@ TEST(Jit64, ConvertDoubleToSingle)
Core::DeclareAsCPUThread();
Common::ScopeGuard cpu_thread_guard([] { Core::UndeclareAsCPUThread(); });
- TestCommonAsmRoutines routines(Core::System::GetInstance());
+ const TestCommonAsmRoutines routines(Core::System::GetInstance());
for (const u64 input : double_test_values)
{
diff --git a/Source/UnitTests/Core/PowerPC/Jit64Common/Frsqrte.cpp b/Source/UnitTests/Core/PowerPC/Jit64Common/Frsqrte.cpp
index 7c6bf963f4..a59f577c7b 100644
--- a/Source/UnitTests/Core/PowerPC/Jit64Common/Frsqrte.cpp
+++ b/Source/UnitTests/Core/PowerPC/Jit64Common/Frsqrte.cpp
@@ -64,13 +64,13 @@ TEST(Jit64, Frsqrte)
Core::DeclareAsCPUThread();
Common::ScopeGuard cpu_thread_guard([] { Core::UndeclareAsCPUThread(); });
- TestCommonAsmRoutines routines(Core::System::GetInstance());
+ const TestCommonAsmRoutines routines(Core::System::GetInstance());
UReg_FPSCR fpscr;
for (const u64 ivalue : double_test_values)
{
- double dvalue = std::bit_cast<double>(ivalue);
+ const double dvalue = std::bit_cast<double>(ivalue);
u64 expected = std::bit_cast<u64>(Common::ApproximateReciprocalSquareRoot(dvalue));
diff --git a/Source/UnitTests/Core/PowerPC/JitArm64/ConvertSingleDouble.cpp b/Source/UnitTests/Core/PowerPC/JitArm64/ConvertSingleDouble.cpp
index 0c138a957c..2fd1a7302a 100644
--- a/Source/UnitTests/Core/PowerPC/JitArm64/ConvertSingleDouble.cpp
+++ b/Source/UnitTests/Core/PowerPC/JitArm64/ConvertSingleDouble.cpp
@@ -98,16 +98,16 @@ public:
FreeCodeSpace();
}
- u64 ConvertSingleToDouble(u32 value) { return convert_single_to_double_lower(value); }
+ u64 ConvertSingleToDouble(const u32 value) const { return convert_single_to_double_lower(value); }
- Pair<u64> ConvertSingleToDouble(u32 value1, u32 value2)
+ Pair<u64> ConvertSingleToDouble(const u32 value1, const u32 value2) const
{
return convert_single_to_double_pair(value1, value2);
}
- u32 ConvertDoubleToSingle(u64 value) { return convert_double_to_single_lower(value); }
+ u32 ConvertDoubleToSingle(const u64 value) const { return convert_double_to_single_lower(value); }
- Pair<u32> ConvertDoubleToSingle(u64 value1, u64 value2)
+ Pair<u32> ConvertDoubleToSingle(const u64 value1, const u64 value2) const
{
return convert_double_to_single_pair(value1, value2);
}
diff --git a/Source/UnitTests/Core/PowerPC/JitArm64/Frsqrte.cpp b/Source/UnitTests/Core/PowerPC/JitArm64/Frsqrte.cpp
index 3a38fa772b..14f1fdfe78 100644
--- a/Source/UnitTests/Core/PowerPC/JitArm64/Frsqrte.cpp
+++ b/Source/UnitTests/Core/PowerPC/JitArm64/Frsqrte.cpp
@@ -57,7 +57,7 @@ TEST(JitArm64, Frsqrte)
Core::DeclareAsCPUThread();
Common::ScopeGuard cpu_thread_guard([] { Core::UndeclareAsCPUThread(); });
- TestFrsqrte test(Core::System::GetInstance());
+ const TestFrsqrte test(Core::System::GetInstance());
for (const u64 ivalue : double_test_values)
{