diff options
| author | Tilka <tilkax@gmail.com> | 2024-07-23 20:16:54 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-23 20:16:54 +0100 |
| commit | 5f4f974b48cde1965c2e46bb1e6abd3d79000271 (patch) | |
| tree | ddf95bdaee9e07d3c73eb671c0b5c4bbbeac6b2f /Source | |
| parent | 2d8f54fdd257840cac63999e99856482d528b11a (diff) | |
| parent | c71ccb548e9baea772e2e900e9eeeadca8ec5341 (diff) | |
Merge pull request #12950 from AdmiralCurtiss/achievement-fix-badge-network-error
AchievementManager: Fix incorrect check on network request return value in FetchBadge()
Diffstat (limited to 'Source')
| -rw-r--r-- | Source/Core/Core/AchievementManager.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index b669a445b1..932ca45656 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -1175,7 +1175,7 @@ void AchievementManager::FetchBadge(AchievementManager::Badge* badge, u32 badge_ } auto http_response = http_request.Get(api_request.url, USER_AGENT_HEADER, Common::HttpRequest::AllowedReturnCodes::All); - if (http_response.has_value() && http_response->size() <= 0) + if (!http_response.has_value() || http_response->empty()) { WARN_LOG_FMT(ACHIEVEMENTS, "RetroAchievements connection failed on image request.\n URL: {}", |