summaryrefslogtreecommitdiff
path: root/Source
diff options
context:
space:
mode:
authorJosJuice <josjuice@gmail.com>2021-04-01 11:28:53 +0200
committerJosJuice <josjuice@gmail.com>2021-04-01 11:28:53 +0200
commitb3f71f7cdc631fda5cbcec51aafd2c7bed226152 (patch)
tree66c34c6bd3fa83aa1accfde246741ee49bd43958 /Source
parent7a16231e98687457afedaa2b848e95e020a148c7 (diff)
JitArm64: Allow DoJit at address 0 (fix launching Wii titles)
JitArm64::DoJit contains a check where it prints a warning and tries to pause emulation if instructed to compile code at address 0. I'm assuming this was done in order to provide a nicer error behavior in cases where PC was accidentally set to null. Unfortunately, it has started causing us problems recently, as 688bd61 writes and runs some code at address 0 to simulate the PPC being held in reset. What makes this worse is that calling Core::SetState from the CPU thread is actually not allowed and will cause a deadlock instead of the intended behavior. I don't believe there is anything on a real console that would stop you from executing code at address 0 (as long as the MMU has been set up to allow it), and Jit64::DoJit doesn't contain any check like this, so let's remove the check.
Diffstat (limited to 'Source')
-rw-r--r--Source/Core/Core/PowerPC/JitArm64/Jit.cpp6
1 files changed, 0 insertions, 6 deletions
diff --git a/Source/Core/Core/PowerPC/JitArm64/Jit.cpp b/Source/Core/Core/PowerPC/JitArm64/Jit.cpp
index 2d9758b248..30f70fe587 100644
--- a/Source/Core/Core/PowerPC/JitArm64/Jit.cpp
+++ b/Source/Core/Core/PowerPC/JitArm64/Jit.cpp
@@ -623,12 +623,6 @@ void JitArm64::Jit(u32)
void JitArm64::DoJit(u32 em_address, JitBlock* b, u32 nextPC)
{
- if (em_address == 0)
- {
- Core::SetState(Core::State::Paused);
- WARN_LOG_FMT(DYNA_REC, "ERROR: Compiling at 0. LR={:08x} CTR={:08x}", LR, CTR);
- }
-
js.isLastInstruction = false;
js.firstFPInstructionFound = false;
js.assumeNoPairedQuantize = false;