diff options
| author | Admiral H. Curtiss <pikachu025@gmail.com> | 2022-10-08 22:24:30 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-08 22:24:30 +0200 |
| commit | da27a3e6bcbc083fcfb58aca814cc0be2d3e2501 (patch) | |
| tree | e62eee059dd3d2e2a535795a2bb5cc8e5d16957c /Source | |
| parent | 1dd30b58f3e7d9cab274b032ab0e9007f1af3c32 (diff) | |
| parent | 4e204a9a1a6bc1f0ef5402f3163d3d27338395c2 (diff) | |
Merge pull request #11095 from K0bin/misc-vulkan
Remove special treatment for Android in video settings
Diffstat (limited to 'Source')
4 files changed, 3 insertions, 14 deletions
diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java index 2a82bdd5b4..6f2816bf3f 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java @@ -197,7 +197,7 @@ public enum BooleanSetting implements AbstractBooleanSetting GFX_ENABLE_VALIDATION_LAYER(Settings.FILE_GFX, Settings.SECTION_GFX_SETTINGS, "EnableValidationLayer", false), GFX_BACKEND_MULTITHREADING(Settings.FILE_GFX, Settings.SECTION_GFX_SETTINGS, - "BackendMultithreading", false), + "BackendMultithreading", true), GFX_WAIT_FOR_SHADERS_BEFORE_STARTING(Settings.FILE_GFX, Settings.SECTION_GFX_SETTINGS, "WaitForShadersBeforeStarting", false), GFX_SAVE_TEXTURE_CACHE_TO_STATE(Settings.FILE_GFX, Settings.SECTION_GFX_SETTINGS, diff --git a/Source/Android/app/src/main/res/values/strings.xml b/Source/Android/app/src/main/res/values/strings.xml index c54a2ead03..23eccd0c10 100644 --- a/Source/Android/app/src/main/res/values/strings.xml +++ b/Source/Android/app/src/main/res/values/strings.xml @@ -339,8 +339,8 @@ <string name="crop">Crop</string> <string name="crop_description">Crops the picture from its native aspect ratio to 4:3 or 16:9. If unsure, leave this unchecked.</string> <string name="progressive_scan">Enable Progressive Scan</string> - <string name="backend_multithreading">Backend Multithreading</string> <!--Backend Multithreading is only disabled by default on Android --> - <string name="backend_multithreading_description">Enables graphics backend multithreading (Vulkan only). May affect performance. If unsure, leave this unchecked.</string> + <string name="backend_multithreading">Backend Multithreading</string> + <string name="backend_multithreading_description">Enables graphics backend multithreading (Vulkan only). May affect performance. If unsure, leave this checked.</string> <string name="defer_efb_invalidation">Defer EFB Cache Invalidation</string> <string name="defer_efb_invalidation_description">Defers invalidation of the EFB access cache until a GPU synchronization command is executed. May improve performance in some games at the cost of stability. If unsure, leave this unchecked.</string> <string name="manual_texture_sampling">Manual Texture Sampling</string> diff --git a/Source/Core/Core/Config/GraphicsSettings.cpp b/Source/Core/Core/Config/GraphicsSettings.cpp index e5056678bd..6f0ee5940c 100644 --- a/Source/Core/Core/Config/GraphicsSettings.cpp +++ b/Source/Core/Core/Config/GraphicsSettings.cpp @@ -69,17 +69,10 @@ const Info<bool> GFX_BORDERLESS_FULLSCREEN{{System::GFX, "Settings", "Borderless const Info<bool> GFX_ENABLE_VALIDATION_LAYER{{System::GFX, "Settings", "EnableValidationLayer"}, false}; -#if defined(ANDROID) -const Info<bool> GFX_BACKEND_MULTITHREADING{{System::GFX, "Settings", "BackendMultithreading"}, - false}; -const Info<int> GFX_COMMAND_BUFFER_EXECUTE_INTERVAL{ - {System::GFX, "Settings", "CommandBufferExecuteInterval"}, 0}; -#else const Info<bool> GFX_BACKEND_MULTITHREADING{{System::GFX, "Settings", "BackendMultithreading"}, true}; const Info<int> GFX_COMMAND_BUFFER_EXECUTE_INTERVAL{ {System::GFX, "Settings", "CommandBufferExecuteInterval"}, 100}; -#endif const Info<bool> GFX_SHADER_CACHE{{System::GFX, "Settings", "ShaderCache"}, true}; const Info<bool> GFX_WAIT_FOR_SHADERS_BEFORE_STARTING{ diff --git a/Source/Core/VideoCommon/VideoConfig.h b/Source/Core/VideoCommon/VideoConfig.h index ff52e96bde..579cf5e30a 100644 --- a/Source/Core/VideoCommon/VideoConfig.h +++ b/Source/Core/VideoCommon/VideoConfig.h @@ -152,11 +152,7 @@ struct VideoConfig final bool bEnableValidationLayer = false; // Multithreaded submission, currently only supported with Vulkan. -#if defined(ANDROID) - bool bBackendMultithreading = false; -#else bool bBackendMultithreading = true; -#endif // Early command buffer execution interval in number of draws. // Currently only supported with Vulkan. |
