diff options
| author | Lioncash <mai.iam2048@gmail.com> | 2022-10-11 09:18:29 -0400 |
|---|---|---|
| committer | Lioncash <mai.iam2048@gmail.com> | 2022-10-11 09:27:34 -0400 |
| commit | dbfb8408d9703e73aa94909e2492cfe3403a809a (patch) | |
| tree | 9c49a85d336a0b360b6f0049488f8ae283753ab0 /Source | |
| parent | f47b11353de1101c2f0f97395e7cab440a1fdd62 (diff) | |
HW: Use unsigned indices in RegisterMMIO where applicable
base is an unsigned variable, so we can make things little more
consistent by making the loop index unsigned so we aren't doing bit
arithmetic with signed types.
MemoryInterface already does this, so we can leave it alone.
No behavioral changes, just a consistency thing.
Diffstat (limited to 'Source')
| -rw-r--r-- | Source/Core/Core/HW/DSP.cpp | 2 | ||||
| -rw-r--r-- | Source/Core/Core/HW/ProcessorInterface.cpp | 2 | ||||
| -rw-r--r-- | Source/Core/Core/HW/VideoInterface.cpp | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/Source/Core/Core/HW/DSP.cpp b/Source/Core/Core/HW/DSP.cpp index 650c35e1d0..3952133748 100644 --- a/Source/Core/Core/HW/DSP.cpp +++ b/Source/Core/Core/HW/DSP.cpp @@ -453,7 +453,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) MMIO::InvalidWrite<u16>()); // 32 bit reads/writes are a combination of two 16 bit accesses. - for (int i = 0; i < 0x1000; i += 4) + for (u32 i = 0; i < 0x1000; i += 4) { mmio->Register(base | i, MMIO::ReadToSmaller<u32>(mmio, base | i, base | (i + 2)), MMIO::WriteToSmaller<u32>(mmio, base | i, base | (i + 2))); diff --git a/Source/Core/Core/HW/ProcessorInterface.cpp b/Source/Core/Core/HW/ProcessorInterface.cpp index bf4cb29f17..37c10580bd 100644 --- a/Source/Core/Core/HW/ProcessorInterface.cpp +++ b/Source/Core/Core/HW/ProcessorInterface.cpp @@ -142,7 +142,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) MMIO::InvalidWrite<u32>()); // 16 bit reads are based on 32 bit reads. - for (int i = 0; i < 0x1000; i += 4) + for (u32 i = 0; i < 0x1000; i += 4) { mmio->Register(base | i, MMIO::ReadToLarger<u16>(mmio, base | i, 16), MMIO::InvalidWrite<u16>()); diff --git a/Source/Core/Core/HW/VideoInterface.cpp b/Source/Core/Core/HW/VideoInterface.cpp index 6e7780857d..5cc8a174d2 100644 --- a/Source/Core/Core/HW/VideoInterface.cpp +++ b/Source/Core/Core/HW/VideoInterface.cpp @@ -433,7 +433,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) })); // Map 8 bit reads (not writes) to 16 bit reads. - for (int i = 0; i < 0x1000; i += 2) + for (u32 i = 0; i < 0x1000; i += 2) { mmio->Register(base | i, MMIO::ReadToLarger<u8>(mmio, base | i, 8), MMIO::InvalidWrite<u8>()); mmio->Register(base | (i + 1), MMIO::ReadToLarger<u8>(mmio, base | i, 0), @@ -441,7 +441,7 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base) } // Map 32 bit reads and writes to 16 bit reads and writes. - for (int i = 0; i < 0x1000; i += 4) + for (u32 i = 0; i < 0x1000; i += 4) { mmio->Register(base | i, MMIO::ReadToSmaller<u32>(mmio, base | i, base | (i + 2)), MMIO::WriteToSmaller<u32>(mmio, base | i, base | (i + 2))); |
